Conversation
…cedures Add a CI deployment section (per-repo fullsend github setup / inference provision / org GitHub App install), a dispatch-design section (inline pull_request wait via lewagon/wait-on-check-action, CEL trigger, pre_script Jira gating), a day-2 variables/secrets management table, and maintenance procedures for bumping the pinned fullsend version and keeping the two plugin-version files in sync. Refresh stale v0.37.0 references. Implements TC-6193 Assisted-by: Claude Code Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Reviewer's GuideExpands fullsend.md from basic usage and release notes into an operational guide for the deployed verify-pr CI integration, covering provisioning, CI-gated dispatch behavior, credentials and variable rotation, version upgrades, and synchronized plugin releases. Sequence diagram for CI-gated verify-pr dispatchsequenceDiagram
participant PR as Pull Request
participant Actions as fullsend-verify-pr.yml
participant Checks as Other CI Checks
participant Dispatch as reusable-dispatch.yml
participant App as GitHub App
participant Harness as fullsend run
participant Jira as Jira
PR->>Actions: opened, synchronized, or reopened
Actions->>Checks: wait-on-check-action
Checks-->>Actions: Terminal results, pass or fail
Actions->>Dispatch: Dispatch verify-pr review matrix
Dispatch->>App: Mint review-role token via OIDC
Dispatch->>Harness: Run verify-pr
Harness->>Jira: pre_script JQL gating
Jira-->>Harness: Review status and ai-generated-jira label
Harness->>Jira: post_script report comment
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="fullsend.md" line_range="145-147" />
<code_context>
+## CI deployment (per-repo GitHub App)
+
+The same pinned harness that runs locally is dispatched automatically in CI, once
+per pull request, after the PR's other checks finish. Three one-time provisioning
+steps stand this up (day-0, run by a repo/org admin); the recurring run then needs
+no manual step.
+
</code_context>
<issue_to_address>
**nitpick:** The installation section says the workflow runs once per pull request, but `fullsend-verify-pr.yml` triggers on every `opened`, `synchronize`, and `reopened` event, so a PR receives a run for each qualifying update rather than only one run in its lifetime. This misleads operators about expected dispatch frequency and report behavior.
**Triggers:** When a PR is pushed to or reopened after its initial creation.
**Suggested fix:** Say that the workflow runs once per qualifying PR event/head revision, with newer runs superseding older ones through the concurrency group.
```suggestion
The same pinned harness that runs locally is dispatched automatically in CI once
per qualifying PR event/head revision, after the PR's other checks finish. Newer runs
supersede older ones through the concurrency group. Three one-time provisioning steps stand this up (day-0, run by a repo/org admin); the recurring run then needs
```
</issue_to_address>Sourcery assessment
Approved.
| The same pinned harness that runs locally is dispatched automatically in CI, once | ||
| per pull request, after the PR's other checks finish. Three one-time provisioning | ||
| steps stand this up (day-0, run by a repo/org admin); the recurring run then needs |
There was a problem hiding this comment.
nitpick: The installation section says the workflow runs once per pull request, but fullsend-verify-pr.yml triggers on every opened, synchronize, and reopened event, so a PR receives a run for each qualifying update rather than only one run in its lifetime. This misleads operators about expected dispatch frequency and report behavior.
Triggers: When a PR is pushed to or reopened after its initial creation.
Suggested fix: Say that the workflow runs once per qualifying PR event/head revision, with newer runs superseding older ones through the concurrency group.
| The same pinned harness that runs locally is dispatched automatically in CI, once | |
| per pull request, after the PR's other checks finish. Three one-time provisioning | |
| steps stand this up (day-0, run by a repo/org admin); the recurring run then needs | |
| The same pinned harness that runs locally is dispatched automatically in CI once | |
| per qualifying PR event/head revision, after the PR's other checks finish. Newer runs | |
| supersede older ones through the concurrency group. Three one-time provisioning steps stand this up (day-0, run by a repo/org admin); the recurring run then needs |
|
Superseded by #305 — reopened with the head branch on the upstream repo so the verify-pr pull_request dispatch gets secrets + OIDC and can run. |
Summary
Documents the deployed verify-pr fullsend install and day-2 operations in
fullsend.md(TC-6180 Req 16). Docs-only change.fullsend github setup,fullsend inference provision(hosted Vertex via WIF), and org GitHub App install.pull_request+lewagon/wait-on-check-action(inline CI wait) instead of check_suite/check_run/workflow_run; CI-result-is-data-not-a-gate; the CEL trigger on the composing child; pre_script Jira JQL gating.vars.*/secrets.*(incl. the Jira Service AccountJIRA_EMAIL/JIRA_API_TOKEN) with how/when to rotate each.fullsend_version: "v0.43.0"); bump + re-validate procedure.plugin.json+marketplace.jsonbumped together.v0.37.0framing in the intro/prerequisites.Verification
Reviewed for accuracy against the deployed sources:
.github/workflows/fullsend-verify-pr.yml,.fullsend/config.yaml,.fullsend/config.base.yaml,.fullsend/harness/verify-pr.yaml, and the two version files. CI checks (CONVENTIONS.md) all green:pytest147 passed,claude plugin validate✔,skillsaw0 errors.Implements TC-6193
🤖 Generated with Claude Code
Summary by Sourcery
Document how to deploy, operate, validate, and upgrade the fullsend verify-pr workflow in CI.
Enhancements:
Documentation: