Skip to content

feat(lifecycle): optional live_stream_id for Drift Check monitor #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Sep 17, 2026
+18 −0
Merged

feat(lifecycle): optional live_stream_id for Drift Check monitor #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/reusable-drift-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@ on:
required: false
type: string
default: ""
live_stream_id:
description: >-
Optional PerformanceStore live_runs stream id for monitor. When empty,
monitor uses preflight/research return CSVs only (not paper/live account
PnL). Set only for a verified account-bound stream.
required: false
type: string
default: ""
secrets:
codex_audit_service_url:
required: false
Expand All @@ -86,6 +94,7 @@ jobs:
LIFECYCLE_PERFORMANCE_BUCKET: ${{ inputs.lifecycle_performance_bucket || vars.LIFECYCLE_PERFORMANCE_BUCKET || '' }}
LIFECYCLE_LOCAL_ROOT: ${{ github.workspace }}/data/lifecycle_store
LIFECYCLE_STRATEGY_PROFILE: ${{ inputs.strategy_profile }}
LIFECYCLE_LIVE_STREAM_ID: ${{ inputs.live_stream_id }}

steps:
- name: Validate trusted caller
Expand Down Expand Up @@ -258,10 +267,15 @@ jobs:
shell: bash
run: |
set -euo pipefail
# Without LIFECYCLE_LIVE_STREAM_ID, monitor reads preflight/research
# portfolio_and_tracker_returns.csv proxies — not paper/live account PnL.
lifecycle_args=()
if [ -n "${LIFECYCLE_STRATEGY_PROFILE:-}" ]; then
lifecycle_args+=(--strategy "${LIFECYCLE_STRATEGY_PROFILE}")
fi
if [ -n "${LIFECYCLE_LIVE_STREAM_ID:-}" ]; then
lifecycle_args+=(--live-stream-id "${LIFECYCLE_LIVE_STREAM_ID}")
fi
quant-lifecycle monitor --domain ${{ inputs.strategy_domain }} "${lifecycle_args[@]}"

- name: Validate lifecycle prerequisites
Expand Down
4 changes: 4 additions & 0 deletions tests/test_reusable_drift_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ def test_reusable_drift_workflow_enforces_lifecycle_preflight() -> None:
assert "caller_pr_head_repository:" in workflow
assert "lifecycle_preflight_artifact:" in workflow
assert "strategy_profile:" in workflow
assert "live_stream_id:" in workflow
assert "LIFECYCLE_LIVE_STREAM_ID: ${{ inputs.live_stream_id }}" in workflow
assert "codex_audit_service_url:" in workflow
assert 'python-version: ${{ inputs.python_version }}' in workflow
assert "LIFECYCLE_PERFORMANCE_BUCKET: ${{ inputs.lifecycle_performance_bucket || vars.LIFECYCLE_PERFORMANCE_BUCKET || '' }}" in workflow
Expand All @@ -36,6 +38,8 @@ def test_reusable_drift_workflow_enforces_lifecycle_preflight() -> None:
assert "SNAPSHOT_REPOSITORY_TOKEN:" not in workflow
assert "LIFECYCLE_STRATEGY_PROFILE: ${{ inputs.strategy_profile }}" in workflow
assert 'lifecycle_args+=(--strategy "${LIFECYCLE_STRATEGY_PROFILE}")' in workflow
assert 'lifecycle_args+=(--live-stream-id "${LIFECYCLE_LIVE_STREAM_ID}")' in workflow
assert "not paper/live account PnL" in workflow
assert 'quant-lifecycle monitor --domain ${{ inputs.strategy_domain }} "${lifecycle_args[@]}"' in workflow
assert 'quant-lifecycle doctor --domain ${{ inputs.strategy_domain }} --require-snapshot --require-backtest --max-freshness-days 7 "${lifecycle_args[@]}"' in workflow
assert 'quant-lifecycle drift --domain ${{ inputs.strategy_domain }} --no-alerts "${lifecycle_args[@]}"' in workflow
Expand Down