fix(ui): finish the selected-category fix for the green accent - #80
Merged
Conversation
0.1.4 landed here one merge before 0.1.5 was published, so Colony was the one consumer left behind — and it is the one that needed it most. v0.10.2 fixed the selected settings category by taking its foreground from contrast_on. On 0.1.4 that function still chose its end from a YIQ luminance threshold, and the threshold mis-sorts the green accent: at 0.578 it takes the near-white branch for a 2.34:1 foreground where near-black gives 7.45:1. So a user on the green accent still had an illegible selected category after the fix that was supposed to make it legible. Colony calls contrast_on in three places — both settings sites and the app tint in app_grid — and all three improve. 0.1.5 also carries the picker check marks, which Colony's accent picker draws.
MotherSphere
changed the title
MotherSphere
added a commit
that referenced
this pull request
Sep 2, 2026
colony-ui 0.1.5 is already on main, under a subject release-please will not act on. Its branch had a single commit saying `chore(deps):`, and GitHub's squash takes the commit's subject rather than the pull request's when there is only one — so the retitle to `fix(ui):` made before merging had no effect. That fix matters to users: v0.10.2 made the selected settings category take its foreground from contrast_on, and on colony-ui 0.1.4 that function still mis-sorted the green accent — 2.34:1 where near-black gives 7.45:1. Anyone on the green accent still had an illegible selected category after the release that was supposed to fix it. The footer below is release-please's own escape hatch for a change sitting on main under the wrong subject. The commit is empty because there is nothing left to change: the code landed in #80. Release-As: 0.10.3
Merged
MotherSphere
added a commit
that referenced
this pull request
Sep 2, 2026
colony-ui 0.1.5 is already on main, under a subject release-please will not act on. Its branch had a single commit saying `chore(deps):`, and GitHub's squash takes the commit's subject rather than the pull request's when there is only one — so the retitle to `fix(ui):` made before merging had no effect. That fix matters to users: v0.10.2 made the selected settings category take its foreground from contrast_on, and on colony-ui 0.1.4 that function still mis-sorted the green accent — 2.34:1 where near-black gives 7.45:1. Anyone on the green accent still had an illegible selected category after the release that was supposed to fix it. The footer below is release-please's own escape hatch for a change sitting on main under the wrong subject. The commit is empty because there is nothing left to change: the code landed in #80. Release-As: 0.10.3
MotherSphere
added a commit
that referenced
this pull request
Sep 2, 2026
release-please derived the entry from the commits it could see, and the only one was the empty Release-As commit — so the changelog read "release 0.10.3" and told a user nothing about whether to update. The three fixes it carries all arrived through the colony-ui 0.1.5 bump in #80, whose subject was `chore(deps)` and therefore invisible to the generator. Written out here rather than left as a chore line.
MotherSphere
added a commit
that referenced
this pull request
Sep 2, 2026
* chore(main): release 0.10.3 * docs(changelog): say what 0.10.3 actually fixes release-please derived the entry from the commits it could see, and the only one was the empty Release-As commit — so the changelog read "release 0.10.3" and told a user nothing about whether to update. The three fixes it carries all arrived through the colony-ui 0.1.5 bump in #80, whose subject was `chore(deps)` and therefore invisible to the generator. Written out here rather than left as a chore line. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: MotherSphere <mothersphere.colony@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.1.4 landed here one merge before 0.1.5 was published, so Colony was the one consumer left behind — and it is the one that needed it most.
v0.10.2 fixed the selected settings category by taking its foreground from
contrast_on. On 0.1.4 that function still chose its end from a YIQ luminance threshold, and the threshold mis-sorts the green accent: at 0.578 it takes the near-white branch for a 2.34:1 foreground where near-black gives 7.45:1.So a user on the green accent still had an illegible selected category after the fix that was supposed to make it legible. 0.1.5 makes
contrast_oncompare the contrast each end actually achieves.Colony calls it in three places — both settings sites and the app identity tint in
app_grid.rs— and all three improve. 0.1.5 also carries the picker check-mark fix, which Colony's accent picker draws.150 tests,
clippyclean.