chore: release 0.10.3 - #81
Merged
Merged
Conversation
colony-ui 0.1.5 is already on main, under a subject release-please will not act on. Its branch had a single commit saying `chore(deps):`, and GitHub's squash takes the commit's subject rather than the pull request's when there is only one — so the retitle to `fix(ui):` made before merging had no effect. That fix matters to users: v0.10.2 made the selected settings category take its foreground from contrast_on, and on colony-ui 0.1.4 that function still mis-sorted the green accent — 2.34:1 where near-black gives 7.45:1. Anyone on the green accent still had an illegible selected category after the release that was supposed to fix it. The footer below is release-please's own escape hatch for a change sitting on main under the wrong subject. The commit is empty because there is nothing left to change: the code landed in #80. Release-As: 0.10.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty commit carrying
Release-As: 0.10.3, because the change it releases is already onmainunder a subject release-please will not act on.What happened
#80 bumped colony-ui to 0.1.5. Its branch had a single commit saying
chore(deps):. GitHub'ssquash_merge_commit_titleisCOMMIT_OR_PR_TITLE, which takes the commit's subject rather than the pull request's whenever the branch has only one commit — so retitling the PR tofix(ui):before merging, which I did specifically so it would release, had no effect.chore(deps): colony-ui 0.1.5is what landed, andchorereleases nothing under Colony's configuration.Written up in Project-Colony-Resources#5 so the next person does not repeat it —
design/releases.mdclaimed the PR title is the changelog entry, which is only true for multi-commit branches.Why it should not wait for the next release
v0.10.2 fixed the selected settings category by taking its foreground from
contrast_on. On colony-ui 0.1.4 that function still chose its end from a luminance threshold that mis-sorts the green accent: 2.34:1 where near-black gives 7.45:1. Anyone using the green accent still had an illegible selected category after the release that was meant to fix it. 0.1.5 is what completes it.Why an empty commit
There is nothing left to change — the code landed in #80.
Release-Asis release-please's documented escape hatch for exactly this: neither a corrected direct push nor a retitle can move a subject that is already onmain.