Skip to content

fix(hosting): hide private platform overrides from module interfaces #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 1 commit into from
Sep 20, 2026
Merged

fix(hosting): hide private platform overrides from module interfaces #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/OpenSwiftUI/Integration/Hosting/AppKit/View/NSHostingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@ open class NSHostingView<Content>: NSView, XcodeViewDebugDataProvider where Cont
// TODO: handle screen change
}

@_spi(ForOpenSwiftUIOnly)
@_implementationOnly
#if OPENSWIFTUI_SWIFTUI_RENDERER
@objc(swiftui_addRenderedSubview:positioned:relativeTo:)
#endif
Expand Down
8 changes: 4 additions & 4 deletions Sources/OpenSwiftUI/Integration/Hosting/UIKit/View/UIHostingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ open class _UIHostingView<Content>: UIView, XcodeViewDebugDataProvider where Con
base.layoutSubviews()
}

@_spi(_)
@_implementationOnly
override dynamic open func _geometryChanged(
_ geometry: UnsafeRawPointer,
forAncestor ancestor: UIView?
Expand Down Expand Up @@ -465,7 +465,7 @@ open class _UIHostingView<Content>: UIView, XcodeViewDebugDataProvider where Con
}

// Audited for 6.5.4
@_spi(_)
@_implementationOnly
override dynamic open func _hitTest(with context: _UIHitTestContext?) -> (UIResponder & _UIGestureRecognizerContainer)? {
defer { currentEvent = nil }
guard GestureContainerFeature.isEnabled else { return nil }
Expand Down Expand Up @@ -525,7 +525,7 @@ open class _UIHostingView<Content>: UIView, XcodeViewDebugDataProvider where Con
}

// Audited for 6.5.4
@_spi(_)
@_implementationOnly
override dynamic open var _childContainers: [any _UIGestureRecognizerContainer] {
guard GestureContainerFeature.isEnabled else { return super._childContainers }
return (responderNode as? ViewResponder)?.childGestureContainers ?? []
Expand Down Expand Up @@ -621,7 +621,7 @@ open class _UIHostingView<Content>: UIView, XcodeViewDebugDataProvider where Con
}
}

@_spi(ForOpenSwiftUIOnly)
@_implementationOnly
#if OPENSWIFTUI_SWIFTUI_RENDERER
@objc(swiftui_insertRenderedSubview:atIndex:)
#endif
Expand Down
Loading