Skip to content

fix(hosting): hide private platform overrides from module interfaces - #1089

Merged
Kyle-Ye merged 1 commit into
mainfrom
optimize/interface
Sep 20, 2026
Merged

Kyle-Ye merged 1 commit into
mainfrom
optimize/interface

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 20, 2026

Copy link
Copy Markdown
Member

Summary

  • Hide private UIKit and AppKit hosting overrides from public, private, and package Swift interfaces with @_implementationOnly.
  • Preserve the required override declarations and Objective-C dispatch for geometry, hit testing, gesture containers, and rendered subview insertion.

Validation

  • Verified interface emission and unchanged Swift methods and Objective-C thunks for the UIKit and AppKit insertion hooks.
  • Verified rendered subview insertion through Objective-C selectors with focused runtime probes on iOS 18.5, iOS 26.2, and macOS.

@github-actions github-actions Bot added area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. platform: iOS iOS-specific behavior or support. type: bug Something is not working correctly. labels Sep 20, 2026
@codecov

codecov Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.10%. Comparing base (5af2b2b) to head (40b3789).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
+ Coverage   28.87%   33.10%   +4.23%     
==========================================
  Files         750      803      +53     
  Lines       55271    63659    +8388     
==========================================
+ Hits        15958    21076    +5118     
- Misses      39313    42583    +3270     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tuist

tuist Bot commented Sep 20, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1241 0 1241 30d6c4ace

Failed Tests ❌

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 1m 17s 30d6c4ace

@Kyle-Ye Kyle-Ye changed the title fix(hosting): hide private UIKit overrides from module interfaces fix(hosting): hide private platform overrides from module interfaces Sep 20, 2026
@Kyle-Ye
Kyle-Ye requested a review from Mx-Iris as a code owner September 20, 2026 15:54
@github-actions github-actions Bot added the platform: macOS macOS-specific behavior or support. label Sep 20, 2026
@Kyle-Ye
Kyle-Ye merged commit 74edeb5 into main Sep 20, 2026
5 of 6 checks passed
@Kyle-Ye
Kyle-Ye deleted the optimize/interface branch September 20, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. platform: iOS iOS-specific behavior or support. platform: macOS macOS-specific behavior or support. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant