Skip to content

fix(hosting): avoid false AppKit subview warnings #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 1 commit into from
Sep 13, 2026
Merged

fix(hosting): avoid false AppKit subview warnings #1081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Sources/OpenSwiftUI/Integration/Hosting/AppKit/View/NSHostingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,8 +926,18 @@ open class NSHostingView<Content>: NSView, XcodeViewDebugDataProvider where Cont
// TODO: handle screen change
}

@objc(swiftui_addRenderedSubview:positioned:relativeTo:) // FIXME: ViewUpdater -> AppKitAddSubview
private func openswiftui_addRenderedSubview(_ view: NSView, positioned place: NSWindow.OrderingMode, relativeTo otherView: NSView?) {
@_spi(ForOpenSwiftUIOnly)
#if OPENSWIFTUI_SWIFTUI_RENDERER
@objc(swiftui_addRenderedSubview:positioned:relativeTo:)
#endif
override public func openswiftui_addRenderedSubview(
_ subview: Any,
positioned place: Int,
relativeTo otherView: Any?
) {
let view = subview as! NSView
let place = NSWindow.OrderingMode(rawValue: place)!
let otherView = otherView as! NSView
isInsertingRenderedSubview = true
addSubview(view, positioned: place, relativeTo: otherView)
isInsertingRenderedSubview = false
Expand Down
Loading