Skip to content

fix(hosting): avoid false AppKit subview warnings - #1081

Merged
Kyle-Ye merged 1 commit into
mainfrom
bugfix/appkit_rendered_subview
Sep 13, 2026
Merged

fix(hosting): avoid false AppKit subview warnings#1081
Kyle-Ye merged 1 commit into
mainfrom
bugfix/appkit_rendered_subview

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Override the AppKit rendered-subview insertion hook in NSHostingView.
  • Match the conditional Objective-C selector pattern used by UIKit hosting.

@Kyle-Ye
Kyle-Ye requested a review from Mx-Iris as a code owner September 13, 2026 20:57
@github-actions github-actions Bot added area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. platform: macOS macOS-specific behavior or support. type: bug Something is not working correctly. labels Sep 13, 2026
@Kyle-Ye
Kyle-Ye force-pushed the bugfix/appkit_rendered_subview branch from 729b1dc to f8b3a16 Compare September 13, 2026 21:03
@Kyle-Ye
Kyle-Ye merged commit dbd2dfb into main Sep 13, 2026
3 of 5 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/appkit_rendered_subview branch September 13, 2026 21:03
@tuist

tuist Bot commented Sep 13, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1224 0 1224 d6f3cfc81

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 1m 36s d6f3cfc81

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.23%. Comparing base (a321de1) to head (f8b3a16).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
- Coverage   30.40%   28.23%   -2.18%     
==========================================
  Files         802      749      -53     
  Lines       63525    55199    -8326     
==========================================
- Hits        19317    15584    -3733     
+ Misses      44208    39615    -4593     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. platform: macOS macOS-specific behavior or support. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant