Skip to content

feat(phase): add sounds to the lobby countdown - #166

Merged
Joltras merged 4 commits into
mainfrom
feature/lobby-countdown-sound
Aug 9, 2026
Merged

feat(phase): add sounds to the lobby countdown#166
Joltras merged 4 commits into
mainfrom
feature/lobby-countdown-sound

Conversation

@theEvilReaper

@theEvilReaper theEvilReaper commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Currently, the game is quite quiet while the timer is running. To improve the atmosphere, this pull request adds sounds at specific timestamps.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Test results

204 files  204 suites   1m 34s ⏱️
238 tests 234 ✅  4 💤 0 ❌
717 runs  705 ✅ 12 💤 0 ❌

Results for commit a93b3f6.

@Joltras Joltras added the area: game Everything related to the the game module label Aug 9, 2026
@Joltras
Joltras merged commit a282883 into main Aug 9, 2026
8 checks passed
@Joltras
Joltras deleted the feature/lobby-countdown-sound branch August 9, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: game Everything related to the the game module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants