Skip to content

[16.0][IMP] base_geoengine: Display legends for records with coordinates - #456

Open
anusriNPS wants to merge 1 commit into
OCA:16.0from
PyTech-SRL:16.0-enhance-legend
Open

anusriNPS wants to merge 1 commit into
OCA:16.0from
PyTech-SRL:16.0-enhance-legend

Conversation

@anusriNPS

@anusriNPS anusriNPS commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

While styling legends, using records which has coordinates details in order to display legend information in the geoengine view.

Before this PR fix:
Listing all four locations information in legend
image

After fix:
Legends display information only for records shown in map(i.e records with coordinates details)

image

@quirino95 quirino95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review: LGTM!

@HekkiMelody HekkiMelody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

Comment thread test-requirements.txt Outdated
@@ -1 +1,2 @@
odoo-test-helper
odoo-addon-base_geoengine @ git+https://github.com/OCA/geospatial.git@refs/pull/454/head#subdirectory=setup/base_geoengine

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: please specify in the main message that this PR depends on #454

Usually this line is added in a separate commit so it can be easily removed later once #454 is merged.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed dependencies commit as this PR was related to #417 which is already merged

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 13, 2026
   While styling legends, using records which has coordinates details
in order to display legend information in the geoengine view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved mod:base_geoengine Module base_geoengine series:16.0 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants