Conversation
anusriNPS
marked this pull request as draft
September 14, 2026 11:48
anusriNPS
force-pushed
the
18-port-from-16-base_geoengine
branch
2 times, most recently
from
September 16, 2026 13:42
b0de23b to
72f338d
Compare
anusriNPS
marked this pull request as ready for review
September 16, 2026 13:43
anusriNPS
changed the title
When a record in record panel does not contain latitude and longitude details, the user is notified to update required details to view the record.
While styling legends, using records which has coordinates details in order to display legend information in the geoengine view.
anusriNPS
force-pushed
the
18-port-from-16-base_geoengine
branch
from
September 16, 2026 14:27
72f338d to
6701dc8
Compare
anusriNPS
changed the title
HekkiMelody
suggested changes
Sep 18, 2026
Contributor
There was a problem hiding this comment.
Tested locally with fieldservice_geoengine, I still have the error
Steps to reproduce:
- Edit
fieldservice.action_fsm_locationto addgeoengineto the view modes - Navigate to Field Service > Master Data > Locations and switch to geoengine mode
- Click on "Test Location"
Traceback (with debug=assets on)
UncaughtPromiseError > TypeError
Uncaught Promise > can't access property "add", this.notification is undefined
Occured on localhost:18069 on 2026-09-18 08:51:00 GMT
TypeError: can't access property "add", this.notification is undefined
onDisplayPopupRecord@http://localhost:18069/web/assets/debug/web.assets_web.js:187145:13 (/base_geoengine/static/src/js/views/geoengine/geoengine_renderer/geoengine_renderer.esm.js:583)
onDisplayPopupRecord@http://localhost:18069/web/assets/debug/web.assets_web.js:188341:20 (/base_geoengine/static/src/js/views/geoengine/records_panel/records_panel.esm.js:52)
template/hdlr2<@http://localhost:18069/web/assets/debug/web.assets_web.js line 13850 > Function:36:29 (/web/static/lib/owl/owl.js:5857)
mainEventHandler@http://localhost:18069/web/assets/debug/web.assets_web.js:14183:25 (/web/static/lib/owl/owl.js:6190)
listener@http://localhost:18069/web/assets/debug/web.assets_web.js:8410:20 (/web/static/lib/owl/owl.js:417)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port forwarded below commits:
#454 - Adapted for 18.0 and JS error seen in 16.0 is no longer observered in 18.0 - Port forwarded commit helps to notify user to update coordinate details if not linked with record.
#456 - Same behaviour is observered in 18.0, hence port forwarded it.