Skip to content

build(test-infra): pin prometheus and grafana image tags #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varex83agent wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

build(test-infra): pin prometheus and grafana image tags #680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test-infra/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ services:
command: -config.file=/etc/promtail/config.yml

prometheus:
image: prom/prometheus:latest
image: prom/prometheus:v3.14.0

@emlautarom1 emlautarom1 Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using the same versions as the ones pinned in the smoke tests:

pluto/test-infra/compose/testdata/TestDockerCompose_run_mixed_impls_yml.golden

Line 214 in 78e79c2

image: prom/prometheus:${PROMETHEUS_VERSION:-v2.50.1}

pluto/test-infra/compose/testdata/TestDockerCompose_run_mixed_impls_yml.golden

Line 226 in 78e79c2

image: grafana/grafana:${GRAFANA_VERSION:-10.4.2}

This way whenever we reference "Prometheus" or "Grafana" we're always talking about the same versions. This is specially true since the versions used there and the ones proposed in this PR differ on major.

volumes:
- ./prometheus.yml:/etc/prometheus/prometheus.yml
- ./rules.yml:/etc/prometheus/rules.yml
Expand All @@ -29,7 +29,7 @@ services:
- "host.docker.internal:host-gateway" # Allows access to host machine

grafana:
image: grafana/grafana:latest
image: grafana/grafana:12.4.9
ports:
- "3000:3000"
environment:
Expand Down