build(test-infra): pin prometheus and grafana image tags - #680
Open
varex83agent wants to merge 1 commit into
Open
build(test-infra): pin prometheus and grafana image tags#680varex83agent wants to merge 1 commit into
varex83agent wants to merge 1 commit into
Conversation
Closes #90. Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
emlautarom1
requested changes
Sep 1, 2026
emlautarom1
left a comment
emlautarom1
left a comment
Collaborator
There was a problem hiding this comment.
We should also pin all dependencies listed in test-infra:
- Nethermind
- Lighthouse
- Teku
among other minor tools (ex. curl). These will most likely not be affected by #597 so we can work on them now.
|
|
||
| prometheus: | ||
| image: prom/prometheus:latest | ||
| image: prom/prometheus:v3.14.0 |
Collaborator
There was a problem hiding this comment.
I'd suggest using the same versions as the ones pinned in the smoke tests:
This way whenever we reference "Prometheus" or "Grafana" we're always talking about the same versions. This is specially true since the versions used there and the ones proposed in this PR differ on major.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90.
Pins the previously floating
prom/prometheus:latestandgrafana/grafana:latestcontainer images to explicit release tags in the test-infra compose files, so the observability stack is reproducible. Addresses the review note from charon-rs#82 to pin all dependencies even in examples.Co-Authored-By: Bohdan Ohorodnii 35969035+varex83@users.noreply.github.com