Skip to content

test(governance): verify canonical estate paths on every platform #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rldyourmnd merged 1 commit into from
Sep 7, 2026
Merged

test(governance): verify canonical estate paths on every platform #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions core/app/github_governance_operations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,14 @@ func TestGovernanceExplicitEstateOverridesEnvironmentForPolicy(t *testing.T) {
t.Fatal(err)
}
}
canonical, err := filepath.EvalSymlinks(explicit)
if err != nil {
t.Fatal(err)
}
alias := filepath.Join(t.TempDir(), "selected-estate")
if err := os.Symlink(explicit, alias); err != nil {
t.Fatal(err)
}
// Only the explicit estate contains the repository's selected profile.
if err := os.Remove(filepath.Join(registered, "policies", "stacks", "continuous-development.yaml")); err != nil {
t.Fatal(err)
Expand All @@ -166,7 +174,7 @@ func TestGovernanceExplicitEstateOverridesEnvironmentForPolicy(t *testing.T) {
options := GitHubGovernanceOperationOptions{
GitHubGovernanceOptions: GitHubGovernanceOptions{
GitHubReadOptions: GitHubReadOptions{
EstateRoot: explicit, RuntimeConfig: runtimePath,
EstateRoot: alias, RuntimeConfig: runtimePath,
InstallationID: "installation:github-opennetwork",
},
Owner: "NDDev-OpenNetwork", Repository: "github-device-sync", CompareLocal: true,
Expand All @@ -176,7 +184,7 @@ func TestGovernanceExplicitEstateOverridesEnvironmentForPolicy(t *testing.T) {
if failure != nil {
t.Fatalf("explicit policy root was not honored: %#v", failure)
}
if current.estateRoot != explicit || current.observer(services).estateRoot != explicit {
if current.estateRoot != canonical || current.observer(services).estateRoot != canonical {
t.Fatal("operation and precondition observer did not bind the selected estate")
}
read := services.GitHubGovernance(context.Background(), root, options.GitHubGovernanceOptions)
Expand Down
Loading