Skip to content

Address Copilot review follow-ups from #26 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robin-maxxton merged 1 commit into from
Aug 28, 2026
Merged

Address Copilot review follow-ups from #26 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Artifacts publish to Maxxton's internal Maven registry, not Maven Central - no G

`microdocs-crawler-gradle` and `microdocs-core-java` use the `com.maxxton.convention` plugin, which configures the publication and registry automatically. `microdocs-crawler-doclet` never publishes its own artifact - only its fat jar is bundled into `microdocs-crawler-gradle`'s published jar.

Released versions are immutable in Artifact Registry: republishing a version that already exists fails with `400 Bad Request`. Bump the version rather than republishing.

To publish a new version:
1. Bump `version` in `gradle.properties` for whichever module(s) changed.
2. Run:
Expand All @@ -16,5 +18,4 @@ $ ./publish.sh
```

### Java 8
Checkout the java8 branch for a Java 8 compatible version. The master branch is based on Java 21.

Checkout the java8 branch for a Java 8 compatible version. The master branch is based on Java 25.
1 change: 0 additions & 1 deletion microdocs-crawler-doclet/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ apply plugin: 'base'

repositories {
mavenCentral()
mavenLocal()
maven {
url "artifactregistry://europe-maven.pkg.dev/dynamic-concept-192711/maxxton-maven-virtual"
}
Expand Down