Address Copilot review follow-ups from #26 - #27
Merged
Conversation
… document JDK 25 The doclet resolved microdocs-core-java from mavenLocal() before Artifact Registry, so a stale ~/.m2 copy could mask what is actually published and make local builds disagree with publish.sh/CI. publish.sh publishes core to the registry before the doclet builds, so mavenLocal() is not needed here. README still claimed master is based on Java 21; it has been on JDK 25 since MXTS-77488.
There was a problem hiding this comment.
Pull request overview
Follow-up to PR #26 by aligning documentation and build behavior with the intended publish flow: avoid inadvertently using stale locally-cached artifacts, and update repository documentation to reflect the current JDK baseline and Artifact Registry constraints.
Changes:
- Removed
mavenLocal()from the doclet module’s repository list to prevent local~/.m2artifacts from overriding published ones. - Updated the root README to reflect Java 25 (instead of Java 21) and documented Artifact Registry’s “no republish of existing versions” behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updates publishing notes (immutable versions) and corrects the documented Java baseline to 25. |
| microdocs-crawler-doclet/build.gradle | Removes mavenLocal() to ensure dependency resolution matches what CI/publish uses. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rsonke-maxxton
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on the Copilot review comments left on #26.
mavenLocal()ordering in the doclet (comment) — valid. WithmavenLocal()ahead of Artifact Registry, a stale~/.m2copy ofmicrodocs-core-javawins over what is actually published, so a local build can disagree withpublish.sh/CI.publish.shpublishes core to the registry before the doclet builds, somavenLocal()isn't needed here at all — removed rather than reordered.README says Java 21 (comment) — the
.java-versionis correct; the README was stale. The repo moved to JDK 25 in MXTS-77488. Docs updated, toolchain untouched.Also documented that released versions are immutable in Artifact Registry, since republishing an existing version fails with an unhelpful bare
400 Bad Request.Not addressed: the missing
pluginManagementblock inmicrodocs-crawler-doclet/settings.gradle(comment). The doclet uses only built-in Gradle plugins viaapply plugin:and doesn't use theplugins {}DSL orcom.maxxton.convention, so the block would resolve nothing today. It becomes relevant if the doclet is aligned with the other two modules — worth a separate change.🤖 Generated with Claude Code
https://claude.ai/code/session_018pqXcKnVEhEThnbSD9KgV4