Corrected the build and publish process - #26
Merged
Conversation
rsonke-maxxton
approved these changes
Aug 28, 2026
There was a problem hiding this comment.
Pull request overview
Updates the Gradle configuration to support building/publishing against a Google Artifact Registry Maven repository, and sets a repo-wide Java version.
Changes:
- Add Google Artifact Registry Gradle plugin initialization in
microdocs-crawler-doclet/settings.gradle. - Add the Artifact Registry Maven repository to
microdocs-crawler-doclet/build.gradle. - Introduce a root
.java-versionfile (currently set to Java 25).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| microdocs-crawler-doclet/settings.gradle | Adds Artifact Registry Gradle plugin bootstrap so the artifactregistry:// repository scheme can be used. |
| microdocs-crawler-doclet/build.gradle | Adds an Artifact Registry Maven repository for dependency resolution. |
| .java-version | Sets the repo-wide Java version used by common version managers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
12
| buildscript { | ||
| repositories { | ||
| gradlePluginPortal() | ||
| } | ||
| dependencies { | ||
| classpath("com.google.cloud.artifactregistry.gradle-plugin:com.google.cloud.artifactregistry.gradle-plugin.gradle.plugin:2.2.5") | ||
| } | ||
| } | ||
|
|
||
| apply plugin: com.google.cloud.artifactregistry.gradle.plugin.ArtifactRegistryGradlePlugin | ||
|
|
||
| rootProject.name = 'microdocs-crawler-doclet' |
Comment on lines
6
to
12
| repositories { | ||
| mavenCentral() | ||
| mavenLocal() | ||
| maven { | ||
| url "artifactregistry://europe-maven.pkg.dev/dynamic-concept-192711/maxxton-maven-virtual" | ||
| } | ||
| } |
| @@ -0,0 +1 @@ | |||
| 25 | |||
robin-maxxton
added a commit
that referenced
this pull request
Aug 28, 2026
… document JDK 25 The doclet resolved microdocs-core-java from mavenLocal() before Artifact Registry, so a stale ~/.m2 copy could mask what is actually published and make local builds disagree with publish.sh/CI. publish.sh publishes core to the registry before the doclet builds, so mavenLocal() is not needed here. README still claimed master is based on Java 21; it has been on JDK 25 since MXTS-77488.
robin-maxxton
added a commit
that referenced
this pull request
Aug 28, 2026
…adme-jdk Address Copilot review follow-ups from #26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.