Add the Zano migration design doc - #19
Open
j0ntz wants to merge 2 commits into
Open
Conversation
This was referenced Aug 25, 2026
The wallet status' two height fields are not in the same units, so a synced wallet reported one block past the chain and every confirmation read one high. Section 6 gains the conversion, Testing gains the unit and in-app coverage plus the explorer's own convention, and the phase history gains the phase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical Design Document
zano-migration-off-module-queue.md
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Docs only.
Description
Adds the technical design document for the Zano native-module-queue migration, updated to describe what actually ships in #18 and EdgeApp/edge-currency-accountbased#1092.
The document was written across the seven investigation phases that produced #17 and #1090, and until now it existed only on that branch. Those two PRs are closed in favour of Matt's pair, so without this the design record disappears with the branch, along with every link to it from the task, the run reports, and the PR bodies.
Section 8's phase 8 covers what changed in the rebuild: the persistence strategy (the synced-branch store alone never fires for a wallet weeks behind, so
checkpointCatchupcycles the wallet to force a write mid-scan), the mempool sweep moving after the paging loop, the HF6 payment-id handling, and theAddressInfocorrection. Sections 5, 6, 9, and 11 are updated to match the shipping code rather than the first round.Open items are recorded rather than smoothed over: the
checkpointCatchuprace with an in-flightbroadcastTx, the redundant offset-zero fetch, andrunWalletbeing private while postponed-run makes it mandatory for every open.Testing
No code changes. Markdown links and anchors checked against the section headings.