docs(tui): COR-226 session-shared lock_v2 scene - #72
Merged
Merged
Conversation
cursor
Bot
force-pushed
the
cursor/cor-226-session-shared-lock-95cc
branch
from
September 13, 2026 17:40
a1924a6 to
174b221
Compare
2 similar comments
Contributor
Author
Greptile SummaryThis PR adds the session-shared lock-v2 scene and a dim, width-aware read-only share-link marker to the TUI status chrome. It also updates scene assets and coverage, and strengthens fade constructor tests. Confidence Score: 5/5Safe to merge. No outstanding issues remain. The previously reported design-spec scope statement is corrected, and the fade tests now sample newly constructed fades directly, preserving constructor initialization coverage. Reviews (7): Last reviewed commit: "test(core): sample fade constructor with..." | Re-trigger Greptile |
cursor
Bot
force-pushed
the
cursor/cor-226-session-shared-lock-95cc
branch
from
September 13, 2026 17:58
aa70c30 to
233f157
Compare
Contributor
Author
Designer cli LOCK — COR-226 session-sharedVerdict: LOCK (chrome lockable) on head QA designer + runtime 40×12 and 120×40
@alexa chrome is lockable — undraft/squash when CI + Greptile green. |
cursor
Bot
force-pushed
the
cursor/cor-226-session-shared-lock-95cc
branch
from
September 13, 2026 18:40
b98a5df to
33f127e
Compare
Add designer and runtime lock boards for a live read-only /share link at 40x12 and 120x40. The Shared marker is dim status chrome on the header row; /unshare clears it by dropping the live link. Co-authored-by: Mathis <echobt@users.noreply.github.com>
nextest can delay a worker tens of milliseconds between Fade construction and progress(), so a 100ms fade-in was already past mid-curve on CI. Use a long duration and reset() immediately before sampling. Co-authored-by: Mathis <echobt@users.noreply.github.com>
Keep the 60s duration for nextest scheduling, but assert constructor progress() directly so fade_in/fade_out start timestamps stay covered. Co-authored-by: Mathis <echobt@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/cor-226-session-shared-lock-95cc
branch
from
September 13, 2026 18:42
33f127e to
de4cba2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COR-226 —
/share·/unshareShared status-line markerAdds one lock_v2 ui-state,
session-shared, at both sizes (40×12 and 120×40) — designer boards, runtime captures, and txt grids — plus the runtime chrome the board needs.Linear: COR-226 — cli shortcut: /share and /unshare (title only; no label/status change).
Head SHA:
de4cba2— rebased ontoorigin/maintip98eb2c5(#71, on top of #69/#70). Session-shared runtime PNG bytes unchanged.What the board locks
Interactive session chrome while a read-only share link is live:
Shared · read-onlyat 120 cols,Sharedat 40 cols — dim#6B7280, never accent, never a wash. Persistent chrome, not a one-shot toast: it stays up for as long as the link is live and the token counter keeps its right-aligned slot./shareuser bar plus dim system copy — the minted read-only URL oncortex.foundation/share/9f4c2a71, a “copied to your clipboard” note (wide only), and the/unshareway out.>caret) and the footer stays the normal session footer — no hold, no approval sheet.Sharedin the marker and shortens the URL line to just the link./unshareis idle chrome: clearingAppState::share_linkdrops the marker. No/unsharesheet, no/sharebackend work in this PR.Runtime wiring
AppState::share_link: Option<String>— live read-only link,Noneafter/unshare.ui::chrome::paint_status_marker— dim header-row marker at the left margin, clipped so it never runs into the token counter.ui::consts::SHARE_MARKER/SHARE_MARKER_NARROW.lock_v2_share.rs— thesession-sharedscene plus its tests, split out solock_v2.rskeeps its line-count baseline (same pattern aslock_v2_network.rs/lock_v2_parity.rs).Counts
After rebase onto #71: 96 wide / 50 narrow. Keeps #71 (
theme-picker,handoff-confirm,session-fork,init-agents,custom-commands,hooks-lifecycle), #70, and #69.pngDelta
pngDelta: 0fordocs/media/tui-lock-v2/runtime/**files that existed before the rebase. Session-shared runtime SHA256s:120x40/session-shared.pngb07f2a98abc7e53412810c4b4fed463163ea1e152a84c1535c97ab0e966991c640x12/session-shared.png7b15b2a2ef28afdc7d895c04cb91fed17673a6a87ce14ec410ebd4430a387e8eVerification
apply_designed_sceneandapply_share_scene).60sduration; constructorprogress()withoutreset()).Test plan
cargo fmt --all -- --check./scripts/clippy.shcargo test -p cortex-tui --lib lock_v2and animation fade testscargo audit(or note a documented.cargo/audit.tomlexception)Attestation (required)
I attest that:
lock_v2_share.rsplus fade scheduler-safe assertions. No mocks that report success..envfiles are included.Risk
Lock board count assertions must stay aligned with #71 + session-shared. Recapturing runtime PNGs would break the byte-identical LOCK.