feat(tui): residual lock chrome (COR-6/7/9–17/21)

[echobt]

Summary

Draft lock-chrome residual for Cortex CLI / Cortex Code. Rebased onto origin/main (0621bf5, after #71 and #72). Head bc3a188.

Latest: inline picker click zones follow the same stack as paint when update/opt-in banners force a short-terminal collapse (picker is not always composer_y - height).

Stay draft. Existing lock PNGs from this branch were kept; no runtime PNG bytes were regenerated. Main-only lock scenes from #69/#70/#71/#72 are now on the branch as inherited files.

Test plan

• cargo fmt --all -- --check
• scripts/readiness/quality.py --base origin/main — 0 regressions
• cargo test -p cortex-tui --lib --no-default-features -- picker_layout

Attestation (required)

I attest that:

• Security reviewed — auth, exec, sandbox, path traversal, network egress, and secret handling in this diff were reviewed. No secrets, tokens, or keyring dumps are in the change.
• Product-facing errors — user-visible failures use Cortex product copy. API-down paths say The coding service is temporarily unavailable. No raw provider, SDK, or transport names.
• TUI verified — picker click-zone tests including cramped banners.
• Tests added — cramped-stack geometry plus painted-row hit test. No mocks that report success.
• No secrets — no API keys, WorkOS secrets, R2/AWS credentials, or .env files are included.

  

[cursor]

@greptileai

[cursor]

@greptileai

[echobt]

Designer cli LOCK — residual COR-7/9/10/14/15

Verdict: LOCK (chrome lockable; undraft/squash when CI + Greptile green).

QA on head faba22eb runtime samples (40×12 + 120×40): shortcuts-overlay, diff-hunk, composer-typing, goal-chip-active, interrupt-stopped, todos

• Ink chrome #000/#F5F5F5/#6B7280/#1F4945; green #4ADE80 only on +diff (allowed)
• Zero violet / blue / competitor names
• Linear COR-7/9/10/14/15 already Already designed

@alexa chrome is lockable for this residual pack. HOLD only if a later push reintroduces violet/#A78BFA or competitor strings.

[cursor]

@greptileai

[greptile-apps]

Greptile Summary

This draft adds session-sharing command surfaces and related TUI chrome, but the new /share command is not connected to a session action. Users can enter the command, but it reports that no operation was performed instead of creating a read-only link.

Confidence Score: 4/5

Not safe to merge until /share creates and reports a usable session share link.

The reproduced /share failure prevents an advertised session action from working. The following prior threads were resolved without explanatory replies by cursor[bot], which differs from the Greptile bot login, so cursor[bot] manually resolved them without explanation: the live checklist was not populated; compact shortcut rows remained selectable when hidden; off-sheet clicks selected shortcut rows; Ctrl+x took focus from active prompts and modals; the stopped fixture did not show the stopped composer placeholder; checklist events were unwired; shortcut focus interrupted active interactions; stopped guidance persisted after clearing or changing sessions; third-party model identities collapsed to Custom model; inline picker mouse targets did not match painted rows; picker click zones ignored banner heights; and TodoWrite checklist updates could be dropped when the event queue was full.

Files Needing Attention: src/cortex-tui/src/commands/executor/session.rs

T-Rex Logs

What T-Rex did

• T-Rex produced a proof for a posted P1 finding and linked it to the review comment.
• T-Rex produced a second finding-proof for the same P1 finding to reinforce the evidence.
• T-Rex validated the contract behavior by comparing the UI before and after submitting /share 1h, confirming the rendered transcript shows an unsupported command message.
• T-Rex traced the code paths responsible for handling the share command to explain why the command is not matched and falls through.
• Artifacts were prepared to enable reviewers to verify both the finding-proof and the contract-validation-proof.

_{Ran code and verified through T-Rex}

Comments Outside Diff (2)

1. src/cortex-tui/src/commands/executor/session.rs, line 51-56 (link)

   Handle Share Actions

   The new /share command returns asynchronous share actions, but the session event loop has no matching handler. Submitting /share 1h reports “Unsupported command in this session: share:1h. No operation was performed.” instead of creating a link. Users therefore cannot share a session or activate the advertised Shared status.

   Knowledge Base Used:

   • Application TUI sessions and views
   • Interactive terminal experience
   Artifacts

   
   

   Evidence from the check

   • Temporary-script-backed focused test injects, runs, captures, and restores a `/share 1h` composer-path test, demonstrating the actual event-loop result.

   Command output from the check

   • Captured cargo-test output shows the exact command, working directory, exit code 0, before/after terminal renders, and the unsupported-command result.

   TUI before submitting `/share 1h`

   • Rasterized runtime TUI buffer shows `/share 1h` entered in the composer before submission, establishing the command under test.

   TUI after submitting `/share 1h`

   • Rasterized runtime TUI buffer shows `Unsupported command in this session: share:1h. No operation was performed.`, confirming no share action occurred.

   Evidence from the check

   • Exact text buffer captured from the executed test immediately before the composer submits `/share 1h`, preserving the pre-action UI.

   Evidence from the check

   • Exact text buffer captured from the executed test after submission, preserving the unsupported-command UI result.

   

   _{Ran code and verified through T-Rex}

2. General comment

   /share async results fall through as unsupported commands

   • Bug
     • The command executor accepts /share and /share <duration>, but an actual /share 1h composer submission renders Unsupported command in this session: share:1h. No operation was performed. No share link/status is produced.
   • Cause
     • cmd_share returns CommandResult::Async("share") or CommandResult::Async("share:<duration>"), while EventLoop::handle_async_command has no share or share: match arm and invokes its unsupported-command fallback.
   • Fix
     • Add explicit share / share:<duration> handling in EventLoop::handle_async_command that creates the link, updates app_state.share_link, and renders/copies a user-visible success result; cover default and duration forms with an event-loop integration test.

   _{Ran code and verified through T-Rex}

_{Reviews (15): Last reviewed commit: "fix(tui): import computer lock scenes af..." | Re-trigger Greptile}

[cursor]

@greptileai

[cursor]

@greptileai

[cursor]

@greptileai Rebased onto main after #67. Head 971a0a6. Please re-review: distinct custom-model picker labels, file splits under 1000 lines, and lock PNGs including offline/rate-limit from #67.

[cursor]

@greptileai Head 14888ae. Inline picker click zones now start after banner/subtitle/search chrome (MCP, permissions, clear-confirm, resume). Source policy still 0 regressions vs main. Lock PNGs unchanged this push. Stay draft.

[cursor]

@greptileai Head a6ea3aa. Source policy already under 1000-line / complexity targets. This push fixes the TUI/Test failure (/sessions inline resume picker) and changed-line coverage on verify_mcp keyboard map. Stay draft.

[cursor]

@greptileai Head fd77b5d. Picker click zones now use the same short-terminal stack as paint (update + opt-in above the picker). Stay draft.

[echobt]

Designer cli LOCK (reaffirm) — residual COR-6/7/9–17/21

Verdict: LOCK on head fd77b5dc (post-picker-click fixes after prior LOCK on faba22eb).

Spot QA runtime 40×12: shortcuts-overlay, diff-hunk, composer-typing

• Ink chrome #000 / #F5F5F5 / #6B7280 / #262626; violet px = 0
• No competitor strings in samples
• Linear must ui-state children already Already designed

@alexa chrome still lockable — undraft/squash when CI + Greptile green.

[cursor]

@greptileai

[cursor]

@greptileai Head 1ba238b. Rebased onto origin/main after #67/#69/#70. Existing LOCK PNG blobs kept byte-identical; only new boards from main were added. Compact shortcut hits, Ctrl+x focus, live TodoWrite checklist, and stale stopped placeholder are addressed. Stay draft.

[cursor]

@greptileai Head 81b9e48. Rebased onto origin/main after #67/#69/#70. Existing LOCK PNG blobs kept byte-identical; only new boards from main were added. Compact shortcut hits, Ctrl+x focus, live TodoWrite checklist, stale stopped placeholder, and source-policy complexity vs main are addressed. Stay draft.

[cursor]

@greptileai Head 3803205. TodoWrite checklist is applied on spawn from args and restored from completion output, so a full tool-event queue cannot drop Working n/m. Stay draft.

[cursor]

@greptileai Head 2b3e3a0. Rebased onto origin/main after #71 (98eb2c5). Existing LOCK PNG blobs kept byte-identical; only new boards from main (#71 theme/fork/init/hooks/handoff) were inherited. Stay draft.

[cursor]

@greptileai Head 5b3aced. Rebased onto origin/main after #71 (98eb2c5). Existing LOCK PNG blobs kept byte-identical; only new boards from main (#71) were inherited. Computer-scene import restored after the rebase. Stay draft.

[cursor]

@greptileai Head bc3a188. Rebased onto origin/main after #71 and #72 (0621bf5). Existing LOCK PNG blobs kept byte-identical; only new boards from main were inherited (session-shared from #72). Stay draft.

[greptile-apps]

Too many files changed for review (112 files, 100 file limit).

Bypass the limit by tagging @greptile-apps to review.