refactor: separated control stacked widget into pages - #299
Robert0Mart wants to merge 2 commits into
Conversation
16f61b6 to
90444fa
Compare
|
Two bugs found, both with suggested fixes:
if values[0] == "252,50" and values[1] == "250" and values[2] == "50": values are floats (per the .2f/.3f formatting right above), so this string comparison never matches. The branch is unreachable. The literals also look like a typo ("252,50" uses a comma). Suggested fix, using a tolerance instead of exact equality: import math
self.setObjectName("fans_page") Copy-paste leftover from FansPage, overwrites the "extruder_page" name set in init. Fix: self.setObjectName("extruder_page") Rest of the extraction (axis/extruder/temperature/fans logic, signal wiring, create_display_button removal) looks correct. |
Description
BlocksScreen/lib/panels/controlTab.py
BlocksScreen/lib/panels/mainWindow.py
BlocksScreen/lib/panels/widgets/ControlTab/printcorePage.py
BlocksScreen/lib/panels/widgets/ControlTab/probeHelperPage.py
BlocksScreen/lib/panels/widgets/ControlTab/axisPage.py
BlocksScreen/lib/panels/widgets/ControlTab/extruderPage.py
BlocksScreen/lib/panels/widgets/ControlTab/fansPage.py
BlocksScreen/lib/panels/widgets/ControlTab/temperaturePage.py
BlocksScreen/lib/ui/controlStackedWidget.ui
BlocksScreen/lib/ui/controlStackedWidget_ui.py