Skip to content

Refator: filament tab pages organisation - #302

Open
Robert0Mart wants to merge 4 commits into
ref/controlTab-stackedWidgetfrom
ref/filamentTab-stackedWidget
Open

Robert0Mart wants to merge 4 commits into
ref/controlTab-stackedWidgetfrom
ref/filamentTab-stackedWidget

Conversation

@Robert0Mart

@Robert0Mart Robert0Mart commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Stacked PR — merge order

This PR is stacked on top of:

  1. refactor main window stacked widget #298
  2. refactor: separated control stacked widget into pages #299

Do not merge until #298 and #299 are merged first.

CI won't run here until the base becomes dev (after the parents merge).

Description

  • Refactor

BlocksScreen/lib/panels/filamentTab.py

  • aligned main button to the rest of the tabs
  • updated import

BlocksScreen/lib/panels/widgets/FilamentTab/addFilamentPage.py
BlocksScreen/lib/panels/widgets/FilamentTab/addSpoolPage.py
BlocksScreen/lib/panels/widgets/FilamentTab/amuPage.py
BlocksScreen/lib/panels/widgets/FilamentTab/amuWidgets.py
BlocksScreen/lib/panels/widgets/FilamentTab/basicFilamentPanel.py
BlocksScreen/lib/panels/widgets/FilamentTab/spoolmanPage.py

  • moved pages to their own folder for better organisation

BlocksScreen/lib/ui/filamentSensorsPage.ui
BlocksScreen/lib/ui/filamentSensorsPage_ui.py
BlocksScreen/lib/ui/filamentStackedWidget.ui
BlocksScreen/lib/ui/filamentStackedWidget_ui.py

  • deleted unused ui files

@Robert0Mart Robert0Mart changed the title Ref/filament tab stacked widget Refator: filament tab pages organisation Aug 13, 2026
@Robert0Mart
Robert0Mart marked this pull request as ready for review August 13, 2026 16:47
@Robert0Mart Robert0Mart added the Refactor Enhancing code's readability, maintainability, and extensibility while addressing technical debt. label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Enhancing code's readability, maintainability, and extensibility while addressing technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant