Skip to content

fix: clear release preflight lint on agents-api.php and the AS stub #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 2 commits into from
Sep 9, 2026
Merged

fix: clear release preflight lint on agents-api.php and the AS stub #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72f043f
fix: clear release preflight lint on agents-api.php and the AS stub
chubes4 Sep 9, 2026
bff2f0a
fix: keep glob() false-narrowing for PHPStan
chubes4 Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions agents-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,24 @@
// absent, without repeating registration side effects.
$agents_api_load_symbol_file = static function ( string $file ): void {
$namespace = '';
$tokens = token_get_all( (string) file_get_contents( $file ) );
// Local plugin source, not a remote URL; wp_remote_get() does not apply.
$tokens = token_get_all( (string) file_get_contents( $file ) ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents
$count = count( $tokens );

for ( $index = 0; $index < $count; ++$index ) {
// Single cursor over the token stream; nested scans advance it deliberately.
$index = 0;
while ( $index < $count ) {
$token = $tokens[ $index ];
++$index;
if ( ! is_array( $token ) ) {
continue;
}

if ( T_NAMESPACE === $token[0] ) {
$namespace = '';
for ( ++$index; $index < $count; ++$index ) {
while ( $index < $count ) {
$namespace_token = $tokens[ $index ];
++$index;
if ( ';' === $namespace_token || '{' === $namespace_token ) {
break;
}
Expand All @@ -63,12 +68,13 @@
if ( ! in_array( $token[0], array( T_CLASS, T_INTERFACE, T_TRAIT ), true ) ) {
continue;
}
if ( T_CLASS === $token[0] && T_DOUBLE_COLON === ( $tokens[ $index - 1 ][0] ?? null ) ) {
if ( T_CLASS === $token[0] && T_DOUBLE_COLON === ( $tokens[ $index - 2 ][0] ?? null ) ) {
continue;
}

for ( ++$index; $index < $count; ++$index ) {
while ( $index < $count ) {
$symbol_token = $tokens[ $index ];
++$index;
if ( is_array( $symbol_token ) && T_STRING === $symbol_token[0] ) {
$namespace = trim( $namespace );
$symbol = '' === $namespace ? $symbol_token[1] : $namespace . '\\' . $symbol_token[1];
Expand All @@ -81,9 +87,11 @@
}
};

$agents_api_symbol_files = array_merge(
glob( __DIR__ . '/src/*/class-*.php' ) ?: array(),
glob( __DIR__ . '/src/*/interface-*.php' ) ?: array(),
$agents_api_class_files = glob( __DIR__ . '/src/*/class-*.php' );
$agents_api_interface_files = glob( __DIR__ . '/src/*/interface-*.php' );
$agents_api_symbol_files = array_merge(
is_array( $agents_api_class_files ) ? $agents_api_class_files : array(),
is_array( $agents_api_interface_files ) ? $agents_api_interface_files : array(),
array( __DIR__ . '/src/Channels/register-default-agents-chat-handler.php' )
);
foreach ( $agents_api_symbol_files as $agents_api_symbol_file ) {
Expand Down
4 changes: 3 additions & 1 deletion stubs/action-scheduler-classes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ public static function is_initialized( ?string $function_name = null ): bool {
* Resets stale claims / marks abandoned actions failed.
*/
class ActionScheduler_QueueCleaner {
public function __construct( ?ActionScheduler_Store $store = null, int $batch_size = 20 ) {}
public function __construct( ?ActionScheduler_Store $store = null, int $batch_size = 20 ) {
unset( $store, $batch_size );
}

/**
* @return array<int,int|string>
Expand Down