fix: clear release preflight lint on agents-api.php and the AS stub - #542
Merged
Conversation
Rewrite the symbol-file tokenizer loop as an explicit cursor (the nested for-loops advanced the outer index on purpose, which PHPCS flags as a jumbled incrementer), expand the two short ternaries, annotate the local-file file_get_contents, and consume the stub constructor params.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release preflight for v0.10.0 failed on 7 findings, all pre-existing on v0.8.0/v0.9.0 but surfaced as baseline-new because #541 touched those files by one line each.
agents-api.php: the symbol-file tokenizer used nestedforloops that deliberately advance the outer$index(PHPCSJumbledIncrementer). Rewritten as a single explicit cursor with post-increment; theT_DOUBLE_COLONlook-behind adjusts from- 1to- 2accordingly. Two short ternaries expanded;file_get_contentson a local plugin path annotated.stubs/action-scheduler-classes.php: consume the unused stub constructor params.Full
composer smokegreen (the bootstrap loader is exercised by every smoke). No behavior change.AI-generated with Claude Code via Homeboy worktree