Skip to content

⚡ Bolt: [performance improvement] Memoize regex compilations in ConText lexicon #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zrt219 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: [performance improvement] Memoize regex compilations in ConText lexicon #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-18 - Missing Memoization for Regex Compilations
**Learning:** `_compiled_context_lexicon` function inside `openmed/openmed/clinical/context.py` compiles multiple heavy regular expressions dynamically without memoization. The function is called for every span context resolution (`resolve_temporality`, `resolve_uncertainty`, etc), leading to severe performance bottlenecks.
**Action:** Always memoize deterministic regex compilations and lexicon generation in NLP pipelines (e.g. `openmed.clinical`) using `@functools.lru_cache` to prevent bottlenecks during repeated string/span evaluations. Make sure to only cache hashable parameters.
5 changes: 4 additions & 1 deletion openmed/openmed/clinical/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@

from __future__ import annotations

import functools
import re
import types
from collections.abc import Iterable, Iterator, Mapping, Sequence
from dataclasses import dataclass, replace
from datetime import date
Expand Down Expand Up @@ -154,6 +156,7 @@ class _CompiledContextLexicon:
backward_context_cues: frozenset[str]


@functools.lru_cache(maxsize=None)
def _compiled_context_lexicon(language: str | None = None) -> _CompiledContextLexicon:
lexicon = get_clinical_cue_lexicon(language)
token_boundaries = lexicon.token_boundaries
Expand Down Expand Up @@ -195,7 +198,7 @@ def _compiled_context_lexicon(language: str | None = None) -> _CompiledContextLe
),
token_boundaries=token_boundaries,
),
category_by_text=_cue_category_lookup(lexicon),
category_by_text=types.MappingProxyType(_cue_category_lookup(lexicon)),
backward_context_cues=frozenset(
_normalize_cue_text(cue) for cue in lexicon.backward
),
Expand Down