Skip to content

⚡ Bolt: Optimize context lexicon compilation #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zrt219 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: Optimize context lexicon compilation #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-24 - Memoize deterministic regex compilations and lexicon generation in text-processing pipelines
**Learning:** In NLP or text-processing pipelines (e.g., within `openmed.clinical`), deterministic operations like regex compilations (`re.compile`) and lexicon generation are extremely expensive if called repeatedly per string evaluation. Without memoization, functions like `_compiled_context_lexicon` cause severe performance bottlenecks during span evaluations.
**Action:** Always memoize deterministic regex compilations and lexicon generation (e.g., using `@functools.lru_cache`) when they are repeatedly called per string or span evaluation, provided the return type is immutable (e.g., a frozen dataclass).
2 changes: 2 additions & 0 deletions openmed/openmed/clinical/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@

from __future__ import annotations

import functools
import re
from collections.abc import Iterable, Iterator, Mapping, Sequence
from dataclasses import dataclass, replace
Expand Down Expand Up @@ -154,6 +155,7 @@ class _CompiledContextLexicon:
backward_context_cues: frozenset[str]


@functools.lru_cache
def _compiled_context_lexicon(language: str | None = None) -> _CompiledContextLexicon:
lexicon = get_clinical_cue_lexicon(language)
token_boundaries = lexicon.token_boundaries
Expand Down