feat: forget registered machines from HOSTS - #304
Merged
Conversation
Stale hosts stayed in the sidebar forever: disconnect only marked them offline, and there was no API, CLI, or UI to drop the hub record. Add DELETE /api/machines/:id (cascades tabs/sessions/bookmarks), a machine_removed event, sidebar/mobile Remove host with confirmation, and `webmux machines rm`. Bootstrap now lists every registered host so empty offline machines can be forgotten after reload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
HOSTS accumulated stale machines (
localhost.localdomain, old hostnames) with no way to drop them. Disconnect only marked a machine offline; the DB row lived forever, and the UI had add but not remove.DELETE /api/machines/:idforgets a machine you own. Drops a live connection if any, deletes the DB row (CASCADE tabs / sessions / bookmarks), and broadcastsmachine_removed.webmux machines --alllists offline hosts;webmux machines rm <id|name> [--yes]forgets one (unique name, otherwise id).Online hosts can be forgotten too; the confirm copy warns they will not reconnect until re-registered.
Verification
cargo test -p tc-hub107 passedcargo test -p tc-cli52 passedpnpm test351 passedpnpm typecheckcleanpnpm e2e:test91/91, including newforget-host.spec.ts(register a throwaway host, cancel, then remove)