Allow creating EOAP containers without xcube, and vice versa - #87
Merged
Conversation
write_stac now fails silently if pystac is not available.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 97.64% 97.69% +0.05%
==========================================
Files 6 6
Lines 595 608 +13
Branches 66 66
==========================================
+ Hits 581 594 +13
Misses 9 9
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The call to xcube.util.plugin.init_plugins() is already made in util.start_server (where it belongs).
start_server will now exit with a log message if xcube is not present in the environment, rather than raising an ImportError as before. Related to #56.
-n was already used by --no-eoap.
This allows an xcengine container to run without pystac if it doesn't require EOAP functionality. Related to Issue #56.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56
Still to do:
--no-xcubeand--no-eoap. Some tests gave wrong behaviour for--no-xcube, but it may have been because of duplication of-nshort option (now fixed).