Drop For You self-reply chains aimed at unfollowed users - #99
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Drop For You self-reply chains aimed at unfollowed users#99Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
SelfReplyChainFilter already runs on reverse_chron Following. Phoenix For You did not, so an in-network author replying to themselves toward someone the viewer does not follow still served. CoreData hydrates ancestor_users before this filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
SelfReplyChainFilter already drops an in-network author replying to themselves toward someone the viewer does not follow. reverse_chron Following runs it. Phoenix For You did not.
CoreDataCandidateHydrator fills ancestor_users before filters. The filter keeps non-replies, missing ancestor_users, pure self-chains, and chains whose first non-self ancestor is followed or the viewer.
This is not OON reply drops (OONRetweetReplyFilter). Not conversation-gap VF ancestors (PR 97).
Fix
Run SelfReplyChainFilter on the Phoenix candidate pipeline after SelfTweetFilter. Same filter Following already uses.
Proof
Tests