Honor exclude_videos on quotes of video posts - #98
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Conversation
VideoFilter only checked min_video_duration_ms on the primary card. QuoteHydrator already hydrates quoted_video_duration_ms, but only when the VQV ranking param is on. Fetch that duration when exclude_videos is set and drop quotes of videos the same as native video posts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
VideoFilter drops when min_video_duration_ms is set on the primary card. QuoteHydrator already hydrates quoted_video_duration_ms, but only when EnableQuotedVqvDurationCheck is on (ranking VQV). exclude_videos clients still saw quotes of videos.
This is not muted-keyword quoted text (PR 96). Not mute-on-quote author id (PR 23).
Fix
Fetch quoted video duration when exclude_videos is set. VideoFilter drops if either the primary or the quoted duration is present.
QuoteHydrator is skipped for cached posts (has_cached_posts). Cached quote duration is leftover if the cache payload lacks quoted_video_duration_ms.
Proof
Tests