Expand skipped conversation ancestors before For You VF - #97
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Expand skipped conversation ancestors before For You VF#97Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
Thunder stores [in_reply_to, conversation_root] and skips the middle tweet. Following already expands that gap before VF. Phoenix did not, so AncillaryVFFilter never saw a Drop on the skipped ancestor. Wire ConversationGapAncestorHydrator on the Phoenix candidate path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Thunder stores reply ancestors as [in_reply_to, conversation_root] and skips tweets in the middle of the thread. reverse_chron already runs ConversationGapAncestorHydrator so Following VF sees the skipped ancestor. Phoenix For You did not.
VFCandidateHydrator only fetches and should_drop_ancillary only reads candidate.ancestors. A Drop on the skipped middle tweet never reaches AncillaryVFFilter, so the reply still serves.
This is not muted-keyword ancestor text (PR 96). Not VF dual-role merge (PR 55 / 90).
Fix
Wire ConversationGapAncestorHydrator on the Phoenix candidate pipeline after core data, before QuoteHydrator. Same hydrator Following already uses. It expands [parent, root] to [parent, grandparent, root] when TES says the parent replies to someone else, and records tombstone ancestor ids.
Proof
Tests