Skip to content

Stop scanning wp-cli/wp-cli.github.com for contributors and release notes - #74

Merged
swissspidy merged 1 commit into
mainfrom
claude/wp-cli-release-automation-ntuox0
Aug 8, 2026
Merged

Stop scanning wp-cli/wp-cli.github.com for contributors and release notes#74
swissspidy merged 1 commit into
mainfrom
claude/wp-cli-release-automation-ntuox0

Conversation

@swissspidy

@swissspidy swissspidy commented Aug 7, 2026

Copy link
Copy Markdown
Member

The website repository is no longer maintained, so it never has an open milestone to read from. It is still hardcoded into the bundle-wide repository list in two places:

  • .maintenance/src/Contrib_List_Command.php — the list used when contrib-list is invoked with no repo argument
  • .maintenance/src/Release_Notes_Command.php — the same list in get_bundle_release_notes()

Both paths already tolerated it at runtime (contrib-list hits if ( ! $milestone ) { continue; }, and release-notes reduces over an empty milestone set), so this is not a bug fix — it removes a wasted API call per invocation and stops implying the repo is part of a release.

Both commands are on the critical path of the release automation being added in wp-cli/wp-cli#6352, which calls them to generate the changelog and contributor list.

Testing

php -l passes on both files. The change removes one array element from each list and touches nothing else; no callers pass these lists in, and neither list is exposed outside its own method.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xw2XwqE3C4cGGZ6EbS8p3V


Generated by Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Updated default repository listings to exclude the retired wp-cli/wp-cli.github.com repository.
    • Updated bundled release-note retrieval to skip the retired repository while preserving existing formatting and behavior.

…otes

The website repository is no longer maintained, so it never has an open
milestone to read from. Both bundle-wide code paths skipped it harmlessly at
runtime, but it still cost an API call per invocation and implied the repo was
part of a release.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xw2XwqE3C4cGGZ6EbS8p3V
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c4be61e6-40fe-4e2a-8121-ae472b95500e

📥 Commits

Reviewing files that changed from the base of the PR and between 2951589 and 86409c3.

📒 Files selected for processing (2)
  • .maintenance/src/Contrib_List_Command.php
  • .maintenance/src/Release_Notes_Command.php
💤 Files with no reviewable changes (2)
  • .maintenance/src/Release_Notes_Command.php
  • .maintenance/src/Contrib_List_Command.php

📝 Walkthrough

Walkthrough

The default repository lists for bundle contributor collection and bundle release notes no longer include wp-cli/wp-cli.github.com.

Changes

Bundle repository list updates

Layer / File(s) Summary
Remove the repository from bundle commands
.maintenance/src/Contrib_List_Command.php, .maintenance/src/Release_Notes_Command.php
The contributor and release-note repository lists no longer include wp-cli/wp-cli.github.com. Other command behavior remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the removal of wp-cli/wp-cli.github.com from contributor and release-note scans.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/wp-cli-release-automation-ntuox0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@swissspidy
swissspidy marked this pull request as ready for review August 8, 2026 06:05
@swissspidy
swissspidy requested a review from a team as a code owner August 8, 2026 06:05
Copilot AI lite review requested due to automatic review settings August 8, 2026 06:05
@swissspidy swissspidy added the command:maintenance-contrib-list Related to 'maintenance contrib-list' command label Aug 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the retired wp-cli/wp-cli.github.com repository from the hardcoded “bundle-wide” repository lists used by the maintenance contrib-list and release-notes commands, avoiding an unnecessary GitHub API call and preventing the repo from being implied as part of a release.

Changes:

  • Removed wp-cli/wp-cli.github.com from the default repo list in .maintenance/src/Contrib_List_Command.php.
  • Removed wp-cli/wp-cli.github.com from the bundle repo list iterated by .maintenance/src/Release_Notes_Command.php.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.maintenance/src/Release_Notes_Command.php Stops iterating over the retired repo when gathering bundle release notes.
.maintenance/src/Contrib_List_Command.php Stops including the retired repo in the default bundle repo set for contributor listing.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@swissspidy
swissspidy merged commit 99ff3f8 into main Aug 8, 2026
11 of 12 checks passed
@swissspidy
swissspidy deleted the claude/wp-cli-release-automation-ntuox0 branch August 8, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:maintenance-contrib-list Related to 'maintenance contrib-list' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants