Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # 2.2.0
with:
bun-version: 1.3.14
bun-version: 1.4.2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Bun Versions Are Misaligned

The workflows now use Bun 1.4.2, while package.json still declares packageManager: "bun@1.3.14". This can lead developers and version-management tooling to use a different Bun release than the lint, test, and release jobs. Please update the declared package-manager version to match the new CI pin.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/lint.yml
Line: 29

Comment:
**Bun Versions Are Misaligned**

The workflows now use Bun 1.4.2, while `package.json` still declares `packageManager: "bun@1.3.14"`. This can lead developers and version-management tooling to use a different Bun release than the lint, test, and release jobs. Please update the declared package-manager version to match the new CI pin.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.


- name: Install
run: bun install --frozen-lockfile
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:

- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # 2.2.0
with:
bun-version: 1.3.14
bun-version: 1.4.2

- name: Install all target-specific dependencies
run: bun install --frozen-lockfile --os="*" --cpu="*"
Expand Down Expand Up @@ -214,7 +214,7 @@ jobs:

- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # 2.2.0
with:
bun-version: 1.3.14
bun-version: 1.4.2

- uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # 6.5.0
with:
Expand Down Expand Up @@ -306,7 +306,7 @@ jobs:

- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # 2.2.0
with:
bun-version: 1.3.14
bun-version: 1.4.2

- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # 8.0.1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # 2.2.0
with:
bun-version: 1.3.14
bun-version: 1.4.2

- name: Install
run: bun install --frozen-lockfile
Expand Down