Skip to content

Note that ArduinoOTA is not in the release builds - #362

Merged
softhack007 merged 2 commits into
wled:mainfrom
bharvey88:fix/arduinoota-not-in-builds
Aug 19, 2026
Merged

Note that ArduinoOTA is not in the release builds#362
softhack007 merged 2 commits into
wled:mainfrom
bharvey88:fix/arduinoota-not-in-builds

Conversation

@bharvey88

Copy link
Copy Markdown
Contributor

ArduinoOTA is compiled in only when WLED_ENABLE_AOTA is defined. That flag appears in wled.h, wled.cpp and xml.cpp but is not set anywhere in platformio.ini, so no release build has it, and aOtaEnabled defaults to false. The settings UI also hides the checkbox when it is not compiled in:

https://github.com/wled/WLED/blob/main/wled00/xml.cpp#L671-L673

So the landing page advertised a feature the release binaries do not have, and the settings page documented a row those users never see.

  • The landing page now lists HTTP OTA only.
  • The settings row stays, with a note that it only appears on builds compiled with the flag. Deleting it would strand people who compile their own.

basics/getting-started.md listed ArduinoOTA as an update method; that is removed in #360.

ArduinoOTA is compiled in only when WLED_ENABLE_AOTA is defined, which no
release build sets, and the settings UI hides the checkbox when it is not
compiled in. The landing page advertised it as a feature and the settings
page documented a row that release users never see.
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@softhack007, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 32 minutes

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3d8b59c0-5837-43a2-889d-9b84400b97f2

📥 Commits

Reviewing files that changed from the base of the PR and between 8381bbb and 547ffc1.

📒 Files selected for processing (2)
  • docs/features/settings.md
  • docs/index.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@softhack007

Copy link
Copy Markdown
Member

@bharvey88 thanks, I'll need to think about how we should explain ArduinoOTA .... In fact we changed the default to "disabled" for security reasons in v16.0.0 - need to cross-check if its actually removed completely now 😅

@softhack007
softhack007 merged commit 043d4ab into wled:main Aug 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants