Skip to content

feat: show network details (WPB-27921) - #5176

Merged
ohassine merged 11 commits into
developfrom
show-network-details
Aug 18, 2026
Merged

feat: show network details (WPB-27921)#5176
ohassine merged 11 commits into
developfrom
show-network-details

Conversation

@ohassine

@ohassine ohassine commented Aug 14, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-27921


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Show some network details like, if VPN used, network type and resolved addressed in debug screen

Wire 2026-08-13 at 6_50 PM

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…-info-screen

# Conflicts:
#	app/src/main/kotlin/com/wire/android/di/metro/WireMetroViewModelBindings.kt
#	app/src/main/kotlin/com/wire/android/ui/debug/DebugInfoViewModelFactory.kt
@ohassine
ohassine requested a review from MohamadJaara August 14, 2026 14:31
Base automatically changed from security-providers-info-screen to develop August 18, 2026 08:10
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Aug 18, 2026
# Conflicts:
#	app/src/main/kotlin/com/wire/android/di/AppModule.kt
#	app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/SecurityProvidersScreen.kt
#	app/src/main/kotlin/com/wire/android/ui/debug/securityproviders/SecurityProvidersViewModel.kt
#	app/src/main/res/values/strings.xml
@pull-request-size pull-request-size Bot added size/S and removed size/M labels Aug 18, 2026
@ohassine
ohassine enabled auto-merge August 18, 2026 10:19
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.26%. Comparing base (dd5c6be) to head (7bddcb9).

Files with missing lines Patch % Lines
...ug/securityproviders/NetworkDiagnosticsProvider.kt 0.00% 51 Missing ⚠️
...ug/securityproviders/SecurityProvidersViewModel.kt 0.00% 17 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5176      +/-   ##
===========================================
- Coverage    52.41%   52.26%   -0.15%     
===========================================
  Files          667      668       +1     
  Lines        23846    23913      +67     
  Branches      3932     3943      +11     
===========================================
  Hits         12499    12499              
- Misses       10186    10253      +67     
  Partials      1161     1161              
Files with missing lines Coverage Δ
...ug/securityproviders/SecurityProvidersViewModel.kt 0.00% <0.00%> (ø)
...ug/securityproviders/NetworkDiagnosticsProvider.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5c6be...7bddcb9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 265 tests   2 265 ✅  2m 24s ⏱️
  250 suites      0 💤
  250 files        0 ❌

Results for commit 7bddcb9.

♻️ This comment has been updated with latest results.

@ohassine
ohassine added this pull request to the merge queue Aug 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 1f89697 Aug 18, 2026
21 checks passed
@ohassine
ohassine deleted the show-network-details branch August 18, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants