Skip to content

Fieldset formwidget fields should be translatable - #1528

Open
mjauvin wants to merge 2 commits into
developfrom
make-fieldset-fields-translatable
Open

Fieldset formwidget fields should be translatable#1528
mjauvin wants to merge 2 commits into
developfrom
make-fieldset-fields-translatable

Conversation

@mjauvin

@mjauvin mjauvin commented Aug 24, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved nested form field-set initialization by removing an unnecessary nested-state setting.

@mjauvin mjauvin self-assigned this Aug 24, 2026
@mjauvin mjauvin added the maintenance PRs that fix bugs, are translation changes or make only minor changes label Aug 24, 2026
@mjauvin mjauvin added this to the 1.3.0 milestone Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 10c4ead8-fb76-4d4a-b5d8-7330fe767b05

📥 Commits

Reviewing files that changed from the base of the PR and between af4b34b and d4494c8.

📒 Files selected for processing (1)
  • modules/backend/formwidgets/FieldSet.php
💤 Files with no reviewable changes (1)
  • modules/backend/formwidgets/FieldSet.php

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The nested form widget setup no longer assigns isNested to true during field set initialization.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d4494

This is a narrowly scoped change to make fieldset formwidget fields translatable, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: making fieldset form widget fields translatable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch make-fieldset-fields-translatable

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants