Skip to content

Fix malformed tool registration and lookup steps #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emecii wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix malformed tool registration and lookup steps #302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0db76ca
Remove unreachable aborted-signal check and fix two unparseable steps
emecii Sep 6, 2026
63a8b3e
Address registerTool review feedback
emecii Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,13 +669,12 @@ The <dfn method for=ModelContext>registerTool(<var>tool</var>, <var>options</var
1. If |tool map|[|tool name|] [=map/exists=], then return [=a promise rejected with=] an
{{InvalidStateError}} {{DOMException}}.

1. If |tool name| or {{ModelContextTool/description}} is an empty string, then return [=a promise
rejected with=] an {{InvalidStateError}} {{DOMException}}.
1. If |tool name| is not a non-empty string or |tool|'s {{ModelContextTool/description}} is the
empty string, then return [=a promise rejected with=] an {{InvalidStateError}} {{DOMException}}.

1. If either |tool name| is the empty string, or its [=string/length=] is greater than 128, or if
|tool name| contains a [=code point=] that is not an [=ASCII alphanumeric=], U+005F (_),
U+002D (-), or U+002E (.), then return [=a promise rejected with=] an {{InvalidStateError}}
{{DOMException}}.
1. If |tool name|'s [=string/length=] is greater than 128, or if |tool name| contains a [=code
point=] that is not an [=ASCII alphanumeric=], U+005F (_), U+002D (-), or U+002E (.), then
return [=a promise rejected with=] an {{InvalidStateError}} {{DOMException}}.

1. Let |stringified input schema| be the empty string.

Expand Down Expand Up @@ -833,8 +832,8 @@ The <dfn method for=ModelContext>getTools(<var>options</var>)</dfn> method steps

1. Let |callerOrigin| be |toolRequestor|'s [=Document/origin=].

1. If |toolOwnerIsRequested| be true if |targetOrigin| is [=same origin=] with |callerOrigin|,
or if |from origins| [=list/contains=] |targetOrigin|; otherwise, false.
1. Let |toolOwnerIsRequested| be true if |targetOrigin| is [=same origin=] with

@beaufortfrancois beaufortfrancois Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@emecii emecii Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — kept this editorial correction unchanged in 63a8b3e.

|callerOrigin|, or if |from origins| [=list/contains=] |targetOrigin|; otherwise, false.

1. If |toolOwnerIsRequested| is false, then [=iteration/continue=].

Expand Down
Loading