Fix terminal embedding failure quarantine - #33
Open
blast-hardcheese wants to merge 5 commits into
Open
blast-hardcheese wants to merge 5 commits into
blast-hardcheese wants to merge 5 commits into
Conversation
![adaptcom[bot]](https://avatars.githubusercontent.com/in/1609964?s=60&v=4){kind=small}
There was a problem hiding this comment.
Confidence Score: 1/5
Summary
Adds terminal-error quarantine but breaks synchronous indexing, quarantine cleanup, and readiness reporting; contextual cron also retries rejected inputs. Targeted tests pass; two full-suite failures also reproduce on base because crontab is missing.
Important Files Changed
| File | Overview |
|---|---|
| README.md | Documents terminal quarantine and readiness distinction |
| src/kindex/cli.py | Adds status counts but omits actionable quarantine diagnostics |
| src/kindex/vectors.py | Adds quarantine with indexing, lifecycle, retry, and readiness defects |
| tests/test_embed_queue.py | Updates assertions for expanded drain results |
| tests/test_embedding_quarantine.py | Covers basic quarantine paths but misses reproduced lifecycle and caller regressions |
| return {"status": "empty", "embedded": 0, "pending": 0} | ||
| return {"status": "empty", "embedded": 0, "pending": 0, | ||
| "quarantined": len(quarantine), "drain_complete": True, | ||
| "coverage_complete": not quarantine} |
There was a problem hiding this comment.
Remove quarantine records after successful reindex, deletion, or supersession; otherwise resolved nodes permanently keep coverage_complete false.
| print(f"Indexed nodes: {result.get('indexed_nodes')}") | ||
| print(f"Vector rows: {result.get('vector_rows')}") | ||
| print(f"Queue pending: {result['queue_pending']}") | ||
| print(f"Quarantined: {result.get('quarantined', 0)}") |
There was a problem hiding this comment.
Expose quarantined node IDs and sanitized failure reasons; both human and JSON status currently show only counts, leaving operators unable to identify rejected nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kin embed statusFixes #32.
Test plan
python -m pytest -q tests/test_embedding_quarantine.py tests/test_embed_queue.py tests/test_vectors.py tests/test_cron_reliability.py tests/test_tasks.py tests/test_edit_store.py(205 passed)python -m pytest -qreached an unrelated existing supervisor-acceptance failure: its isolated test shell cannot finddirenv(282 passed, 1 skipped before failure).Risk / rollback
metapayload and older builds ignore it. Revert the commit to resume prior queue-only behavior.