Skip to content

duckdb: don't panic on unsupported Value type - #9243

Merged
myrrc merged 1 commit into
developfrom
myrrc/duckdb-no-panic-on-value-convert
Aug 7, 2026
Merged

duckdb: don't panic on unsupported Value type#9243
myrrc merged 1 commit into
developfrom
myrrc/duckdb-no-panic-on-value-convert

Conversation

@myrrc

@myrrc myrrc commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Now we return an error to the binder instead of panic!.

@myrrc myrrc added changelog/fix A bug fix ext/duckdb Relates to the DuckDB integration labels Aug 6, 2026
@myrrc
myrrc enabled auto-merge (squash) August 6, 2026 15:07
Comment thread vortex-sqllogictest/src/duckdb.rs
@codspeed-hq

codspeed-hq Bot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 34.33%

❌ 2 regressed benchmarks
✅ 1927 untouched benchmarks
⏩ 51 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation decompress[u64, (1000, 16)] 73.1 µs 133.8 µs -45.39%
Simulation decode_varbin[(1000, 2)] 61.5 µs 77.9 µs -21.03%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/duckdb-no-panic-on-value-convert (8259a63) with develop (4e3be5b)

Open in CodSpeed

Footnotes

  1. 51 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc
myrrc force-pushed the myrrc/duckdb-no-panic-on-value-convert branch from 933c39f to 0376ca7 Compare August 6, 2026 15:26
@myrrc
myrrc requested a review from robert3005 August 6, 2026 15:27
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc force-pushed the myrrc/duckdb-no-panic-on-value-convert branch from 0376ca7 to 8259a63 Compare August 7, 2026 09:13
@myrrc
myrrc merged commit 27859f7 into develop Aug 7, 2026
74 of 75 checks passed
@myrrc
myrrc deleted the myrrc/duckdb-no-panic-on-value-convert branch August 7, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants