feat(cli): warn when project-local CLI is missing - #2362
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
3ed8a20 to
7c9b56c
Compare
7c9b56c to
5440075
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e21d37157
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eeb4a77158
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da7e3cee99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
I recall a previous scenario where a project does not deps on |
|
@fengmk2 Direct |
| ## `vpt write-file node_modules/vite-plus/package.json '{"name":"vite-plus","version":"0.0.0"}'` | ||
|
|
||
|
|
||
| ## `vp lint src/index.js` |
There was a problem hiding this comment.
We may need to consider which commands require reminders. For example, vp lint/vp fmt can actually work normally without the project depending on vite-plus?
There was a problem hiding this comment.
I think all commands can work without the project depending on vite-plus, the purpose to show a warning is to tell developers the repo doesn't expect contributors to use Vite+ here. Even if they use Oxlint, as Vite+ version is not pinned, the config and version differs make significant behavior differences.
ea872ef to
824cff8
Compare
2 participants
Close #2361
This PR warns when
vpdelegates inside a project without a resolvable project-localvite-plus, while preserving the global CLI fallback.vite-plusdependency, prompt the user to runvp install.vite-plusdependency, direct the user to the migration guide.vp migrateis run, do not warn because it is the remediation path.The
vp execRFC now distinguishes local-to-global CLI fallback from remote fallback for the command being executed.🤖 Generated with Codex