Skip to content

Upgrade to Smart copy-paste dialog system - #2042

Open
CodeByDrescher wants to merge 20 commits into
masterfrom
FixInitCondMousePaste
Open

Upgrade to Smart copy-paste dialog system#2042
CodeByDrescher wants to merge 20 commits into
masterfrom
FixInitCondMousePaste

Conversation

@CodeByDrescher

Copy link
Copy Markdown
Contributor

This PR is for a few different but related changes.

  1. Smart copy/paste functionality via keybinds has been added to the Initial Conditions Panel.
  2. In the math overrides panel, parameter scans now properly smart copy/paste.
  3. The confirmation dialog for when smart copy/paste occurs has been improved visually and functionally.
  4. Smart copy/paste actions now consistently use the Client Task Dispatcher
  5. Logging improvements

@CodeByDrescher CodeByDrescher self-assigned this Sep 1, 2026
@CodeByDrescher
CodeByDrescher force-pushed the FixInitCondMousePaste branch 2 times, most recently from db5ae6b to e289df0 Compare September 2, 2026 20:20

@danv61 danv61 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about Nameable being so insular since most vcell entities implement getName and setName (anything that extends BioModelEntityObject or implements SymbolTableEntry or EditableSymbolTableEntry and more).
Also, replacing equals with contains is unsafe in the code below:
if (evt.getPropertyName().equals(SelectionManager.PROPERTY_NAME_SELECTED_OBJECTS)) {
if (evt.getPropertyName().contains(SelectionManager.PROPERTY_NAME_SELECTED_OBJECTS)) {
I saw that you annotated the property with metadata, so I understand what you're doing, but it might have been more robust to do the contains first, and if true to really parse the property string, extract the exact property name (first token) and compare strict.
Nice feature!

Lots of similar property changes happen, and this change is to make it easier to track what events were fired when.
This is an important pre-step to fixing bug with param scan smart copy + paste
Note: This work also fixes bug where parameter scans could not be smart copy/pasted correctly.
Better & safer time-stamp isolation when checking event name, and folded Namable into more specific Interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants