Upgrade to Smart copy-paste dialog system - #2042
Conversation
db5ae6b to
e289df0
Compare
There was a problem hiding this comment.
I am not sure about Nameable being so insular since most vcell entities implement getName and setName (anything that extends BioModelEntityObject or implements SymbolTableEntry or EditableSymbolTableEntry and more).
Also, replacing equals with contains is unsafe in the code below:
if (evt.getPropertyName().equals(SelectionManager.PROPERTY_NAME_SELECTED_OBJECTS)) {
if (evt.getPropertyName().contains(SelectionManager.PROPERTY_NAME_SELECTED_OBJECTS)) {
I saw that you annotated the property with metadata, so I understand what you're doing, but it might have been more robust to do the contains first, and if true to really parse the property string, extract the exact property name (first token) and compare strict.
Nice feature!
e289df0 to
9e21588
Compare
Lots of similar property changes happen, and this change is to make it easier to track what events were fired when.
This is an important pre-step to fixing bug with param scan smart copy + paste
Note: This work also fixes bug where parameter scans could not be smart copy/pasted correctly.
Better & safer time-stamp isolation when checking event name, and folded Namable into more specific Interface
9e21588 to
f4ee3db
Compare
This PR is for a few different but related changes.