Conversation
Collaborator
|
Personally anything past 4x is already past diminishing returns on quality, and is substantially more compute intensive. |
Owner
|
Refactoring the code to remove the three nearly-duplicate functions is worth it. But keep the max antialiasing at 4, please! |
MAX-WiRED
force-pushed
the
feat/waveform-smoothing
branch
from
September 5, 2026 08:25
b559db4 to
e3e3067
Compare
uvcat7
requested changes
Sep 6, 2026
uvcat7
left a comment
Owner
There was a problem hiding this comment.
Thanks! Just need to fix this one thing.
| clearBlocks(); | ||
| } | ||
|
|
||
| int antiAliasingFactor() const { return waveformAntiAliasingMode_ + 1; } |
Owner
There was a problem hiding this comment.
Remove this function please and replace its calls with getAntiAliasing.
MAX-WiRED
force-pushed
the
feat/waveform-smoothing
branch
from
September 6, 2026 16:15
e3e3067 to
05f57e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The waveform's anti-aliasing is three functions that differ only in how many
samples they average:
picked by a switch that has to grow an arm for every factor.
The change
One loop covers every factor:
and the switch becomes
The three named functions and the switch go. Nothing else about how a block is
rendered changes.
The list of settings is untouched:
None,2x,3x,4x, as before. Theclamp that used to sit at the call site in
loadSettingsmoved intosetAntiAliasing, so the bound is written once asNUM_AA_MODESrather thanas a bare
3.Testing
Built on Windows with clang-tidy and clang-format enforced, as the build does.
Walked the setting from
Noneto4xon a song with real audio: the list readsas it did, the waveform redraws at each step, and
2x,3xand4xlook theway they did before the change.