fix(request): accept single-byte ranges in parseRange - #262
Closed
shimonewman wants to merge 1 commit into
Closed
Conversation
RFC 9110 byte-range bounds are inclusive, so `bytes=0-0` (a one-byte range, commonly sent by Safari/iOS players probing range support) and a request for a file's final byte are valid. parseRange() rejected any range where start >= end, so these requests parsed as no-range and consumers answered 416. Only start > end is invalid. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Thanks for contributing! This repository is a read-only mirror; development for this library happens in |
Greptile SummaryCorrects
Confidence Score: 5/5The pull request appears safe to merge with no actionable correctness or security issues identified. The changed comparison correctly accepts equal inclusive bounds, retains rejection of start-greater-than-end ranges, and is covered by targeted regression tests. Important Files Changed
Reviews (1): Last reviewed commit: "fix(request): accept single-byte ranges ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9110 byte-range bounds are inclusive, so
bytes=0-0(a one-byte range, commonly sent by Safari/iOS players probing range support) and a request for a file's final byte are valid. parseRange() rejected any range where start >= end, so these requests parsed as no-range and consumers answered 416. Only start > end is invalid.