Skip to content

fix(lights): filter out non-light materials with accidental light colors - #268

Closed
CanerKaraca23 wants to merge 1 commit into
user-grinch:mainfrom
CanerKaraca23:fix-lights-texture-filter
Closed

fix(lights): filter out non-light materials with accidental light colors#268
CanerKaraca23 wants to merge 1 commit into
user-grinch:mainfrom
CanerKaraca23:fix-lights-texture-filter

Conversation

@CanerKaraca23

Copy link
Copy Markdown
Collaborator

Introduce IsLightTexture filter to verify material texture names before classifying them as vehicle lights, preventing car body/chassis materials with matching RGB vertex colors from accidentally glowing as lights.

Copilot AI lite review requested due to automatic review settings August 25, 2026 02:16

This comment was marked as spam.

@AmeerDotEXE
AmeerDotEXE self-requested a review August 25, 2026 06:40

@AmeerDotEXE AmeerDotEXE left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks a bit overboard, im not accepting this pr

@AmeerDotEXE

Copy link
Copy Markdown
Collaborator

@user-grinch would you give a second opinion?

@user-grinch

Copy link
Copy Markdown
Owner

Same this would probably cause more issues than solve.

@user-grinch would you give a second opinion?

@CanerKaraca23

Copy link
Copy Markdown
Collaborator Author

Same this would probably cause more issues than solve.

@user-grinch would you give a second opinion?

Any idea how to solve this then? I sent a video on Discord.

@AmeerDotEXE

Copy link
Copy Markdown
Collaborator

we have patterns for finding nodes
we can have anti-paterns to filter them out
for example filtering out conflicts like ignoring "rev" frame if the character after it is a letter
instead of an underscore or number
or if it commonly mistakes "reverse" for "rev"
we filter out the word reverse from reaching "rev"

applying a global condition could easy cause more issues than it solves
especially since there are too many light types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants