Conversation
PR: urunc-dev#58 Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com> Reviewed-by: Panagiotis Mavrikos <pmavrikos@nubificus.co.uk> Approved-by: Panagiotis Mavrikos <pmavrikos@nubificus.co.uk>
PR: urunc-dev#59 Signed-off-by: char ma <test@mail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Signed-off-by: Md Raiyan <alikhurshid842001@gmail.com>
cmainas
force-pushed
the
main
branch
2 times, most recently
from
September 16, 2026 08:02
5bae1ca to
27f3d06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tests/e2e/ctr_test.gorouted all test cases through a singleDescribeTablecallingrunForegroundTest, regardless of whether a test case had aTestFuncset. Any case with a non-nilTestFuncwould have it silently ignored —runForegroundTestonly checksExpectOut.This change mirrors the pattern in
nerdctl_test.go: aContext("foreground containers")block usingselectTestCases(ctrTestCases(), false)callsrunForegroundTest, and aContext("detached containers")block usingselectTestCases(ctrTestCases(), true)callsrunDetachedTest. No test case logic changes — purely structural.Related issues
ctr_test.goroutes all test cases throughrunForegroundTest, silently ignoringTestFunc#68How was this tested?
tests/e2e/ctr_test.gois the only file changed. The singleDescribeTable(line 46) was replaced with twoContextblocks matchingnerdctl_test.goexactly. The linter passes locally (golangci-lint run -v --timeout=5m); the only reported issues arepre-existing CRLF noise on unmodified files that Linux CI does not flag.
make unittestandmakepass without errors.Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).