Conversation
PR: urunc-dev#58 Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com> Reviewed-by: Panagiotis Mavrikos <pmavrikos@nubificus.co.uk> Approved-by: Panagiotis Mavrikos <pmavrikos@nubificus.co.uk>
PR: urunc-dev#59 Signed-off-by: char ma <test@mail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Signed-off-by: mdryaan <alikhurshid842001@gmail.com>
Contributor
Author
|
Hi @cmainas Could you please have a look on this PR, whenever you get time. |
cmainas
force-pushed
the
main
branch
2 times, most recently
from
September 16, 2026 08:02
5bae1ca to
27f3d06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
verifyNoStaleFilesintests/e2e/utils.gochecks containerd task paths underdefaultandk8s.iobut does not check themobynamespace. Docker uses themobynamespace for containerd tasks. As a result, stale file verification never catches leftover task directories when tests run with Docker, defeating the purpose of the check.Related issues
How was this tested?
tests/e2e/utils.go— added the missing/run/containerd/io.containerd.runtime.v2.task/moby/<containerID>check toverifyNoStaleFiles, following the exact same pattern as the existingdefaultandk8s.iochecks.golangci-lintreports 0 issues.cspellreports 0 issues.make unittestpasses.Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).