feat: add DNS server to guest boot args - #1051
Draft
slash-init wants to merge 1 commit into
Draft
slash-init wants to merge 1 commit into
slash-init wants to merge 1 commit into
Conversation
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds DNS server handling for guests that support configuring DNS through boot/runtime arguments.
The DNS server is read from the OCI
/etc/resolv.confmount and passed throughNetDevParamsto the guest-specific network configuration.Currently this adds DNS handling for:
Tests have also been added for the new DNS handling.
Rumprun is left out for now based on the discussion in #1039, since it does not appear to support configuring DNS through boot arguments.
Related issues
How was this tested?
/etc/resolv.conf->NetDevParams.DNSServerpath still needs end-to-end verification.LLM usage
GPT 5.6 Luna was used to assist with implementation. All generated code was reviewed.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).