Conversation
Avoid file collisions on /tmp/fc.json when multiple Firecracker containers are spawned concurrently or in rapid succession. Use /tmp/fc-<containerID>.json when ContainerID is provided, falling back to /tmp/fc.json if empty. Signed-off-by: Norway-02 <anshulkhetade02@gmail.com>
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
Hi @cmainas, I have updated the PR description and completed the checklist requirements according to the contribution guidelines. Could you please remove the invalid label and review when you get a chance? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When launching containers using the Firecracker hypervisor (
firecracker),firecracker.gopreviously assigned a static configuration file path at/tmp/fc.json. To prevent file collisions or race conditions across concurrent container creations on shared filesystems, this change updatesFirecracker.BuildExecCmdto construct container-isolated configuration paths (/tmp/fc-<containerID>.json) usingargs.ContainerIDwhen available, falling back gracefully to/tmp/fc.jsonwhenContainerIDis omitted.Related issues
How was this tested?
pkg/unikontainers/hypervisors/firecracker_test.gocoveringBuildExecCmdwith and withoutContainerID.go test -v -race -cover ./pkg/unikontainers/hypervisors/...(100% pass, no race conditions).go test -v ./pkg/... ./internal/...(all tests passed).Reviewers
cc @cmainas @OdysseasKalaitsidis
LLM usage
none
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).