Skip to content

Feature/design - #83

Open
miogds wants to merge 3 commits into
untoldengine:developfrom
miolabs:feature/design
Open

Feature/design#83
miogds wants to merge 3 commits into
untoldengine:developfrom
miolabs:feature/design

Conversation

@miogds

@miogds miogds commented Jul 31, 2026

Copy link
Copy Markdown

New design proposal

@untoldengine

Copy link
Copy Markdown
Owner

Thanks for putting this together @lordchronotrigger . I like the new style. However, it seems that the Environment and Effects tab are now gone. Was that done deliberately?

@lordchronotrigger

Copy link
Copy Markdown

Hi Harold, I’m glad you like it. You’ll see those tabs if you click on the project, at the project level in the left-hand panel, since this is something that affects the scene or project globally.

@untoldengine

Copy link
Copy Markdown
Owner

@lordchronotrigger ok, let me look into that again.

@untoldengine

Copy link
Copy Markdown
Owner

Hey @miogds and @lordchronotrigger — thanks for this. The redesign direction is great, and UI_Changes.md made it really easy to review. Please keep doing that on future PRs.

Before I can merge, one thing needs fixing:

Please rebase onto develop. This branch split off before develop bumped Package.swift from UntoldEngine 0.14.20.16.0, so it's currently missing 7 commits, including the serializer fix (7f8dd45c, "fixed abs path in serializer") that resolves a real bug.

On 0.14.2, .untoldscene files bake in an absolute, machine-specific assetBasePath. Reloading a scene on a different machine/path silently breaks asset resolution, causing every .untold model to fall back to the placeholder cube mesh. 0.16.0 fixes this.

Rebasing will also pick back up the .exr HDR import support that's currently regressed on this branch. I confirmed the branch builds fine otherwise — this is purely a stale-dependency issue, not a bug in your changes.

A couple of small cleanups while you're in there:

  1. ToolbarView.swift is left as an empty deprecated stub. Your own notes in UI_Changes.md say it should be git rm'd, so let's actually do that.
  2. There are two leftover Spanish strings: Label("Eliminar", ...) in AssetBrowserView.swift (lines ~680 and ~1747). These should probably be "Delete" to match the rest of the UI, unless localization is intentional here.

Non-blocking, but worth a look when you have time:

  • rightPaneContents's flat-category branch and the new folderContentsView helper duplicate a fair amount of logic (row rendering, tap gestures, delete context menu). It might be worth collapsing these into one path so they don't drift apart later.
  • The forced dark mode (preferredColorScheme(.dark)) is a one-way call to drop light mode. I just want to confirm that's an intentional product decision and not incidental to the redesign.

Once the rebase is in, I'm happy to take another pass and merge. Nice work overall.

@miogds

miogds commented Aug 14, 2026

Copy link
Copy Markdown
Author

For now we are working on the dark mode, because is cool, but the idea is support the light mode on the future

@untoldengine

Copy link
Copy Markdown
Owner

@miogds @lordchronotrigger

There is one feature that is missing. Take a look at this screenshot of the editor before your PR:

Screenshot 2026-08-14 at 6 29 46 AM

It has a button called "load authored" that is enabled when you select a .untold file. This function loads all the color-management and lights that were created in Blender for the scene.

The PR does not have this button:

Screenshot 2026-08-14 at 6 28 20 AM

Aside from this, I really like the new design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants