Skip to content

93 use submodule for shared assets - #95

Merged
Nealium104 merged 4 commits into
mainfrom
93-use-submodule-for-shared-assets
Sep 15, 2026
Merged

Nealium104 merged 4 commits into
mainfrom
93-use-submodule-for-shared-assets

Conversation

@Nealium104

@Nealium104 Nealium104 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

This PR adds the exploreuk-frontpage-assets submodule to enable asset sharing.

Changes

  • Adds with: submodules: true to git workflow files to enable CI to build artifacts with shared images
  • Includes a test during build to ensure that submodules have been initialized and updated before finishing a build
  • Changes paths throughout the repo to use the shared path for shared images

Fixes #93

@Nealium104
Nealium104 added this pull request to stack #96 September 11, 2026 16:56
@Nealium104
Nealium104 marked this pull request as ready for review September 11, 2026 16:57
@Nealium104
Nealium104 requested a review from a team as a code owner September 11, 2026 16:57
nrsa222
nrsa222 previously approved these changes Sep 15, 2026
stack merge was automatically disabled September 15, 2026 17:07

Pull Request is not mergeable

@Nealium104
Nealium104 dismissed nrsa222’s stale review September 15, 2026 17:11

The merge-base changed after approval.

Base automatically changed from 89-include-supporting-organizations-on-findingaid to main September 15, 2026 17:12
@Nealium104
Nealium104 force-pushed the 93-use-submodule-for-shared-assets branch from c1bf9a8 to f3abb4c Compare September 15, 2026 17:12
@Nealium104
Nealium104 requested a review from nrsa222 September 15, 2026 17:12
@Nealium104
Nealium104 merged commit c1371eb into main Sep 15, 2026
3 checks passed
@Nealium104
Nealium104 deleted the 93-use-submodule-for-shared-assets branch September 15, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use submodule for shared assets

2 participants